Update #16
Merged
Update #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove ble fw update since it doesn't work - add .gitattributes
turn off wifi after NTP sync
There was a problem hiding this comment.
Pull Request Overview
This PR disables the firmware update functionality and bumps the library version from 1.4.14 to 1.4.15. The changes remove the "Update Firmware" menu option and comment out related code while adding proper WiFi/Bluetooth cleanup after NTP sync.
- Removed firmware update menu item and commented out related functionality
- Added explicit WiFi and Bluetooth cleanup after NTP synchronization
- Modified RTC initialization to call
begin()on the DS3231 RTC object - Updated version to 1.4.15 and added line-ending normalization
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/config.h | Reduced MENU_LENGTH from 7 to 6 to reflect removal of firmware update menu item |
| src/WatchyRTC.cpp | Removed RTC constructor initialization and added explicit rtc_ds.begin() call in init() |
| src/Watchy.cpp | Commented out firmware update menu handlers and functions; added WiFi/BT cleanup after NTP sync |
| library.properties | Bumped version from 1.4.14 to 1.4.15 |
| library.json | Bumped version from 1.4.14 to 1.4.15 |
| .gitattributes | Added line-ending normalization (LF) for all text files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.