bump crossplane-runtime and crossplane/apis to v2.3.3

[jschoombee]

Description of your changes

This PR adopts crossplane-runtime v2.3.x in upjet/v2, pinned to the latest patch v2.3.3 (along with crossplane/apis/v2 v2.3.3).

The v2.3.0 release relocated the common APIs out of crossplane-runtime into the consolidated github.com/crossplane/crossplane/apis/v2/core/v2 package and renamed the inline-embedded spec/status types. Today upjet still imports the removed paths, so any downstream provider that wants to pick up v2.3.x is blocked.

API compatibility

The two renamed embeds are structurally identical to the originals — same fields, same JSON tags, same kubebuilder defaults:

Old (crossplane-runtime/v2/apis/common/v1)	New (crossplane/apis/v2/core/v2)
ResourceSpec (cluster-scoped MRs)	ClusterManagedResourceSpec
ResourceStatus	ManagedResourceStatus

All other common symbols (Reference, Selector, SecretReference, SecretKeySelector, LocalSecretReference, LocalSecretKeySelector, NamespacedReference, NamespacedSelector, Condition*, ManagementAction*, ManagementPolicies, DeletionPolicy, …) keep their names — only the import path changes. So providers that regenerate after this lands see no CRD schema drift.

Migration applied

1. Imports across 17 hand-written files (pkg/config, pkg/controller, pkg/resource, pkg/terraform, pkg/types, pkg/pipeline, tests/conversion, plus the GoMock fake at pkg/resource/fake/mocks/mock.go): swap the three retired package paths (apis/common, apis/common/v1, apis/common/v2) for github.com/crossplane/crossplane/apis/v2/core/v2. gci re-ordered into the project's import sections.
2. Codegen constants in pkg/types/reference.go: both PackagePathXPCommonAPIs and PackagePathXPV2CommonAPIs now resolve to the consolidated path. They're kept as two constants for source-level backward compatibility — typewriter's UsePackage dedupes by path so emitted imports collapse to a single alias. The types.NewPackage package-name argument corrected from "v1" to "v2" to match the real package declaration.
3. Codegen template in pkg/pipeline/templates/crd_types.go.tmpl:
   • ResourceSpec → ClusterManagedResourceSpec for cluster-scoped CRDs.
   • ResourceStatus → ManagedResourceStatus for the embedded status (both scopes).
4. Embedded type-string fixtures in pkg/types/builder_test.go refreshed to match the new fully-qualified path.
5. tests/conversion/test_resource.go field embeds renamed to ClusterManagedResourceSpec / ManagedResourceStatus.
6. pkg/pipeline/hooks_test.go golden fixture aligned with the updated crd_types.go.tmpl output.
7. .github/workflows/ci.yml: switched all jobs from a pinned GO_VERSION env var to go-version-file: go.mod (including the race-tests job which was missed in the initial commit and caused a GOTOOLCHAIN=local failure against the runner's Go 1.24). The minimum Go floor is now 1.25.11 (set by crossplane-runtime v2.3.3 via go mod tidy).
8. go.mod: crossplane-runtime/v2 v2.2.0 → v2.3.3; new direct require on crossplane/apis/v2 v2.3.3; go mod tidy.
9. docs/upjet-v2-upgrade.md: new "v2.3 common-API migration" subsection with corrected prerequisite ordering (step 1 go mod tidy must succeed before step 2 make generate), plus a scope note on the existing apis section to prevent readers migrating from v2→v2.3 from copying the v1-era import paths below it.

Fixes #663

Note for reviewers: CodeRabbit's path filters exclude go.mod, go.sum, pkg/pipeline/templates/crd_types.go.tmpl, and pkg/resource/fake/mocks/mock.go from automated review. The template change in particular is the most consequential part of the PR — eyes welcome there.

The two codegen constants PackagePathXPCommonAPIs / PackagePathXPV2CommonAPIs are intentionally kept as separate constants (now with identical values) to avoid a source-level break for any downstream that references them directly. Collapsing them to a single constant and simplifying the template's dual-alias scheme is left for a follow-up.

I have:

• Read and followed Upjet's contribution process.
• Verified locally: go vet ./..., gci write with the repo's section config, go generate ./... (no diff), and go test ./... -count=1 (all packages green, including tests/conversion/TestConversionIntegration which exercises the codegen template end-to-end).
• Verified on CI: workflow_dispatch of ci.yml on the fork's branch — lint, unit-tests, check-diff, and race-tests all pass.
• Added backport release-x.y labels — intentionally not requesting a backport: release-2.2 is pinned to a pseudo-version of crossplane-runtime/v2 (pre-v2.2.0) and Go 1.24.13, so pulling v2.3 onto that maintenance line would defeat the point of the line. Forward-only.

How has this code been tested

• go build ./... clean.
• go test ./... -count=1 clean across all 23 packages.
• tests/conversion/TestConversionIntegration exercises the codegen pipeline end-to-end against a test provider and asserts roundtrip conversions across versions, covering the updated crd_types.go.tmpl and new package path constants.
• Fork-side CI (workflow_dispatch): lint, unit-tests, check-diff, and race-tests all green.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

This PR migrates Crossplane common API imports and symbols to github.com/crossplane/crossplane/apis/v2/core/v2 across controllers, resources, tests, codegen constants, CI workflow, and upgrade docs.

Changes

Common API Package Migration

Layer / File(s)	Summary
Controller & config imports pkg/config/resource.go, pkg/controller/api.go, pkg/controller/external.go, pkg/controller/external_async_tfpluginfw.go, pkg/controller/external_async_tfpluginsdk.go, pkg/controller/external_test.go, pkg/controller/external_tfpluginfw.go, pkg/controller/external_tfpluginsdk.go	Update imports to github.com/crossplane/crossplane/apis/v2/core/v2 and switch management-policy, readiness/availability, and reconcile-condition symbols to xpv2 usage.
Resource conditions, sensitive handling, terraform files & tests pkg/resource/conditions.go, pkg/resource/sensitive.go, pkg/resource/sensitive_test.go, pkg/terraform/files.go, pkg/terraform/files_test.go, pkg/terraform/* tests	Migrate condition reason constants and helpers, SecretReference/SecretKeySelector types, SecretClient signatures, GetSensitiveObservation, connection secret reference helpers, and many gomock expectations to core v2 types.
Codegen constants and builder test expectations pkg/types/reference.go, pkg/types/builder_test.go, pkg/pipeline/hooks_test.go	Update package-path constants to core v2 and update builder test expected generated forProvider types and embedded test snippet import paths to reference core v2 selector/reference types.
Test fixtures and conversion resource updates tests/conversion/test_resource.go, pkg/pipeline/hooks_test.go	Update conversion test resource embeds to ClusterManagedResourceSpec/ManagedResourceStatus and switch test imports/mocks to xpv2 types.
CI workflow and docs .github/workflows/ci.yml, docs/upjet-v2-upgrade.md	Bump CI env.GO_VERSION and have setup-go use go-version-file: go.mod; add upgrade guide describing import/embed migrations and regeneration steps.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

• ulucinar
• sergenyalcin

🚥 Pre-merge checks | ✅ 7

✅ Passed checks (7 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	All coding requirements from issue #663 are met: imports migrated to consolidated path, codegen constants updated, template modified for renamed types, test fixtures refreshed, go.mod bumped, and Go version updated.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to issue #663's requirements: API migration, codegen updates, dependency bumps, documentation, and CI toolchain alignment. No unrelated modifications detected.
Configuration Api Breaking Changes	✅ Passed	pkg/config/resource.go contains only internal implementation changes (xpv1→xpv2 dependency migration); no exported types/functions/signatures changed, confirming the PR summary statement.
Generated Code Manual Edits	✅ Passed	No files matching 'zz_*.go' pattern were modified in this PR. All 19 changed files are hand-written source files and documentation, not generated code.
Template Breaking Changes	✅ Passed	Changes to pkg/controller/external*.go are type/import migrations (xpv1→xpv2 APIs) with no business logic or control flow alterations; no actual controller templates were modified.
Title check	✅ Passed	The title is concise, under 72 characters, and clearly describes the Crossplane v2.3.3 bump.
Description check	✅ Passed	The description directly matches the changeset by explaining the v2.3.x API migration, dependency bump, and related codegen updates.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

pkg/pipeline/hooks_test.go (1)

167-178: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Migration looks half-applied in this fixture — import moved, but the embedded type names didn't. 🧐

The import on Line 167 now points to github.com/crossplane/crossplane/apis/v2/core/v2, but Lines 171 and 176 still embed v1.ResourceSpec / v1.ResourceStatus, which were renamed to ClusterManagedResourceSpec / ManagedResourceStatus at the consolidated path. Since baseContent is only a string fixture for marker manipulation (not compiled), the tests still pass — so no functional breakage here. That said, given the crd_types.go.tmpl template now emits the renamed types, updating the fixture keeps it faithful to real generated output and avoids confusing the next maintainer. Was leaving the old names here intentional?

📝 Suggested fixture alignment

 type MemberSpec struct {
-	v1.ResourceSpec ` + "`json:\",inline\"`" + `
+	v1.ClusterManagedResourceSpec ` + "`json:\",inline\"`" + `
 	ForProvider     MemberParameters ` + "`json:\"forProvider\"`" + `
 }

 type MemberStatus struct {
-	v1.ResourceStatus ` + "`json:\",inline\"`" + `
+	v1.ManagedResourceStatus ` + "`json:\",inline\"`" + `
 	AtProvider        MemberObservation ` + "`json:\"atProvider,omitempty\"`" + `
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pkg/pipeline/hooks_test.go` around lines 167 - 178, The fixture import was
updated to github.com/crossplane/crossplane/apis/v2/core/v2 but the embedded
types in MemberSpec and MemberStatus still reference v1.ResourceSpec and
v1.ResourceStatus; update those embeddings to the consolidated names
ClusterManagedResourceSpec and ManagedResourceStatus respectively (e.g., replace
v1.ResourceSpec with ClusterManagedResourceSpec and v1.ResourceStatus with
ManagedResourceStatus in the MemberSpec and MemberStatus structs) so the test
fixture matches the output produced by crd_types.go.tmpl.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/types/reference.go`:
- Around line 22-29: The doc comments above the constants
PackagePathXPCommonAPIs and PackagePathXPV2CommonAPIs are stale/misleading (they
say “Crossplane Runtime package” vs actual target) — update both comments to
describe that they point to the Crossplane core APIs package (e.g., “Crossplane
core APIs”) and optionally note that types like Reference, Selector,
SecretKeySelector, SecretReference, LocalSecretReference,
LocalSecretKeySelector, NamespacedReference, and NamespacedSelector are exported
from github.com/crossplane/crossplane/apis/v2/core/v2 so the consolidation is
safe; change only the comment text near PackagePathXPCommonAPIs and
PackagePathXPV2CommonAPIs without modifying the constant values or other code.

---

Outside diff comments:
In `@pkg/pipeline/hooks_test.go`:
- Around line 167-178: The fixture import was updated to
github.com/crossplane/crossplane/apis/v2/core/v2 but the embedded types in
MemberSpec and MemberStatus still reference v1.ResourceSpec and
v1.ResourceStatus; update those embeddings to the consolidated names
ClusterManagedResourceSpec and ManagedResourceStatus respectively (e.g., replace
v1.ResourceSpec with ClusterManagedResourceSpec and v1.ResourceStatus with
ManagedResourceStatus in the MemberSpec and MemberStatus structs) so the test
fixture matches the output produced by crd_types.go.tmpl.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a1dd9105-d8ff-4e29-a6ae-70adbb07c1d0

📥 Commits

Reviewing files that changed from the base of the PR and between 4edc29a and ab80340.

⛔ Files ignored due to path filters (4)

• go.mod is excluded by none and included by none
• go.sum is excluded by !**/*.sum and included by none
• pkg/pipeline/templates/crd_types.go.tmpl is excluded by none and included by none
• pkg/resource/fake/mocks/mock.go is excluded by !**/fake/** and included by **/*.go

📒 Files selected for processing (17)

• pkg/config/resource.go
• pkg/controller/api.go
• pkg/controller/external.go
• pkg/controller/external_async_tfpluginfw.go
• pkg/controller/external_async_tfpluginsdk.go
• pkg/controller/external_test.go
• pkg/controller/external_tfpluginfw.go
• pkg/controller/external_tfpluginsdk.go
• pkg/pipeline/hooks_test.go
• pkg/resource/conditions.go
• pkg/resource/sensitive.go
• pkg/resource/sensitive_test.go
• pkg/terraform/files.go
• pkg/terraform/files_test.go
• pkg/types/builder_test.go
• pkg/types/reference.go
• tests/conversion/test_resource.go

[Upbound-CLA]

All committers have signed the CLA.

[fernandezcuesta]

Out of the scope of this PR, but we can use go-version-file: go.mod in the setup-go action to avoid this coupling.

[fernandezcuesta]

xpv2? It sounds weird to have this renamed to xpv1

[jschoombee]

Thanks @fernandezcuesta — both addressed:

• xpv1 → xpv2 everywhere (also caught a stray v1 alias in sensitive.go). 8f76572
• go-version-file: go.mod across all three jobs, dropped the env var. 7aa83b7

Fork CI green.