Skip to content

Use Terraform name instead of CRD field name while resolving references #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ulucinar merged 1 commit into from
Aug 5, 2022
Merged

Use Terraform name instead of CRD field name while resolving references #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkg/registry/reference/references.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import (
"github.com/upbound/upjet/pkg/config"
"github.com/upbound/upjet/pkg/registry"
"github.com/upbound/upjet/pkg/types"
"github.com/upbound/upjet/pkg/types/name"
)

const (
Expand Down Expand Up @@ -51,7 +50,7 @@ func getExtractorFuncPath(r *config.Resource, sourceAttr string) string {
if !ok {
return ""
}
return fmt.Sprintf(fmtExtractParamFuncPath, name.NewFromSnake(sourceAttr).LowerCamelComputed, types.IsObservation(s))
return fmt.Sprintf(fmtExtractParamFuncPath, sourceAttr, types.IsObservation(s))

@muvaf muvaf Aug 4, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we used to give fieldName but now field_name. How is this working without a change in other places that processes the output here? Am I missing something?

@ulucinar ulucinar Aug 4, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What Terraformed.GetObservation and Terraformed.GetParameters both return is a map keyed with Terraform argument & attribute names (although they are serialized from spec.forProvider and status.atProvider of the respective CRDs).

@muvaf muvaf Aug 4, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, so it wasn't working before anyway I guess. Thanks for the explanation!

}
}

Expand Down