Skip to content

Upgrade to Go 1.18#36

Merged
muvaf merged 9 commits into
crossplane:mainfrom
epk:epk/go1-18
Aug 1, 2022
Merged

Upgrade to Go 1.18#36
muvaf merged 9 commits into
crossplane:mainfrom
epk:epk/go1-18

Conversation

@epk

@epk epk commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Aditya Sharma git@adi.run

Description of your changes

  • Update to Go 1.18
  • Fix some misc lint errors

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

@muvaf muvaf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @epk ! Let's wait #15 and #12 before merging to avoid conflicts.

Comment thread go.mod
Comment thread pkg/terraform/provider_runner.go Outdated
@muvaf

muvaf commented Aug 1, 2022

Copy link
Copy Markdown
Member

@epk It seems like #15 has less conflict than I imagined, so I think we can merge once you resolve the current conflicts.

epk added 9 commits August 1, 2022 14:59
Signed-off-by: Aditya Sharma <git@adi.run>
Signed-off-by: Aditya Sharma <git@adi.run>
Signed-off-by: Aditya Sharma <git@adi.run>
Signed-off-by: Aditya Sharma <git@adi.run>
Signed-off-by: Aditya Sharma <git@adi.run>
Signed-off-by: Aditya Sharma <git@adi.run>
Signed-off-by: Aditya Sharma <git@adi.run>
Signed-off-by: Aditya Sharma <git@adi.run>
Signed-off-by: Aditya Sharma <git@adi.run>
@epk

epk commented Aug 1, 2022

Copy link
Copy Markdown
Contributor Author

@muvaf rebased but I don't have permissions to merge on this repo.

@muvaf

muvaf commented Aug 1, 2022

Copy link
Copy Markdown
Member

Thanks @epk !!

@muvaf muvaf merged commit 36fb100 into crossplane:main Aug 1, 2022
@epk epk deleted the epk/go1-18 branch August 1, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants