Incompatibility with upstream changes in crossplane-runtime (1.19.0) leading to invalid resources being generated.

[nkvoll]

What happened?

I tried upgrading to upjet 1.8.0 for a project, but it generates code with references to functions that have been removed.

The pointer utility functions were removed in upstream crossplane-runtime here: crossplane/crossplane-runtime#780

Example errors from the build:

Error: apis/[...]/[...]/zz_generated.resolvers.go:36:27: undefined: reference.FromPtrValue
Error: apis/[...]/[...]/zz_generated.resolvers.go:48:84: undefined: reference.ToPtrValue
Error: apis/[...]/[...]/zz_generated.resolvers.go:52:27: undefined: reference.FromPtrValue
Error: apis/[...]/[...]/zz_generated.resolvers.go:64:85: undefined: reference.ToPtrValue
Error: apis/[...]/[...]/zz_generated.resolvers.go:78:27: undefined: reference.FromPtrValue
Error: apis/[...]/[...]/zz_generated.resolvers.go:90:84: undefined: reference.ToPtrValue
Error: apis/[...]/[...]/zz_generated.resolvers.go:94:27: undefined: reference.FromPtrValue
Error: apis/[...]/[...]/zz_generated.resolvers.go:106:85: undefined: reference.ToPtrValue
Error: apis/[...]/[...]/zz_generated.resolvers.go:120:27: undefined: reference.FromPtrValue
Error: apis/[...]/[...]/zz_generated.resolvers.go:132:77: undefined: reference.ToPtrValue
Error: apis/[...]/[...]/zz_generated.resolvers.go:132:77: too many errors

How can we reproduce it?

Try to upgrade upjet to e.g 1.8.0 (anything with a crossplane-runtime dependency > 1.18.0). See crossplane-contrib/provider-upjet-aws#1746

[sergenyalcin]

Hi @nkvoll, this issue is not directly related to the upjet and crossplane-runtime bump. This is related to the order of the dependency updates in the providers. Let me explain.

The crossplane-runtime v1.19.0 removes some functions that are used in generated resolvers. These files are generated via crossplane tools (angryjet). So we also need to bump this package’s version for updating the correct usages. But here, the ordering is so important. Because if you bump the upjet/crossplane-runtime before the crossplane tools or together with it, you will observe the reported problem. So the order must be as described in the release notes (I updated the release notes): https://github.com/crossplane/upjet/releases/tag/v1.8.0. By using the mention order, I am able to generate the provider-aws successfully.

[nkvoll]

@sergenyalcin Thank you for the clear explanation, with this in hand I was also able to generate successfully. Just for completeness sake though, it would have been great if these dependencies were part of upjet, so that bumping upjet also took care of bumping them to the expected versions.

Thank you for adding it to the release notes, and with this issue existing people who just search issues instead of looking directly at the release notes have a breadcrumb to follow. I think we can just close out this issue now.