This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
controller: return the resource as ready as soon as possible #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Right now, even if the resource is ready if we late initialize, a spec update is issued causing that condition update in status to be dropped. So, we wait another reconciliation to update the status. Also,
Plan
call takes a few seconds which also delays the readiness update.Note that we keep the annotation late-initialization, which covers external name, as still high priority since there are cases where we need to get the external name as soon as possible.
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Tested with AWS VPC and we got to
Ready
in42s
compared to77s
previously. Note that in my local, every resource creation performs aterraform init
(includes download over network) because I didn't put the plugin mirroring in place. So, these are not the real numbers only the significance of the difference is.