Skip to content

Change requires-python to match Docker image constraints #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

Change requires-python to match Docker image constraints #97

merged 1 commit into from
Jun 9, 2025
+1 −2

Conversation

dg-nvm
Copy link
Contributor

@dg-nvm dg-nvm commented Nov 28, 2024

Description of your changes

gcr.io/distroless/python3-debian12 is debian12 with python3.11 so package should not be marking by default that it is compatible with 3.12

I have:

  • Read and followed Crossplane's contribution process.
  • [] Added or updated unit tests for my change.

negz
negz approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Sorry for the super delayed review. If you can sign your commit (see failed DCO check instructions) I can merge.

@dg-nvm
Change requires-python to match Docker image constraints
908114d 
Signed-off-by: Dawid Goslawski <dawid.goslawski@vonage.com>
@dg-nvm
Copy link
Contributor Author

dg-nvm commented Jun 9, 2025

@negz no problem, signed-off the commit

@negz negz merged commit a63e997 into crossplane:main Jun 9, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negz negz negz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dg-nvm @negz