Skip to content

Remove providerRef generation #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turkenh merged 1 commit into from
Sep 25, 2023
Merged

Remove providerRef generation #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions cmd/angryjet/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,6 @@ func GenerateManaged(filename, header string, p *packages.Package) error {
methods := method.Set{
"SetConditions": method.NewSetConditions(receiver, RuntimeImport),
"GetCondition": method.NewGetCondition(receiver, RuntimeImport),
"GetProviderReference": method.NewGetProviderReference(receiver, RuntimeImport),
"SetProviderReference": method.NewSetProviderReference(receiver, RuntimeImport),
"GetProviderConfigReference": method.NewGetProviderConfigReference(receiver, RuntimeImport),
"SetProviderConfigReference": method.NewSetProviderConfigReference(receiver, RuntimeImport),
"SetWriteConnectionSecretToReference": method.NewSetWriteConnectionSecretToReference(receiver, RuntimeImport),
Expand Down
11 changes: 0 additions & 11 deletions cmd/breakingChanges/old.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,17 +149,6 @@ spec:
required:
- name
type: object
providerRef:
description: 'ProviderReference specifies the provider that will be
used to create, observe, update, and delete this managed resource.
Deprecated: Please use ProviderConfigReference, i.e. `providerConfigRef`'
properties:
name:
description: Name of the referenced object.
type: string
required:
- name
type: object
publishConnectionDetailsTo:
description: PublishConnectionDetailsTo specifies the connection secret
config which contains a name, metadata and a reference to secret
Expand Down
22 changes: 0 additions & 22 deletions internal/method/method.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,28 +120,6 @@ func NewGetResourceReference(receiver, core string) New {
}
}

// NewSetProviderReference returns a NewMethod that writes a SetProviderReference
// method for the supplied Object to the supplied file.
func NewSetProviderReference(receiver, runtime string) New {
return func(f *jen.File, o types.Object) {
f.Commentf("SetProviderReference of this %s.\nDeprecated: Use SetProviderConfigReference.", o.Name())
f.Func().Params(jen.Id(receiver).Op("*").Id(o.Name())).Id("SetProviderReference").Params(jen.Id("r").Op("*").Qual(runtime, "Reference")).Block(
jen.Id(receiver).Dot(fields.NameSpec).Dot("ProviderReference").Op("=").Id("r"),
)
}
}

// NewGetProviderReference returns a NewMethod that writes a GetProviderReference
// method for the supplied Object to the supplied file.
func NewGetProviderReference(receiver, runtime string) New {
return func(f *jen.File, o types.Object) {
f.Commentf("GetProviderReference of this %s.\nDeprecated: Use GetProviderConfigReference.", o.Name())
f.Func().Params(jen.Id(receiver).Op("*").Id(o.Name())).Id("GetProviderReference").Params().Op("*").Qual(runtime, "Reference").Block(
jen.Return(jen.Id(receiver).Dot(fields.NameSpec).Dot("ProviderReference")),
)
}
}

// NewSetProviderConfigReference returns a NewMethod that writes a SetProviderConfigReference
// method for the supplied Object to the supplied file.
func NewSetProviderConfigReference(receiver, runtime string) New {
Expand Down
40 changes: 0 additions & 40 deletions internal/method/method_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,46 +137,6 @@ func (t *Type) GetProviderConfigReference() *runtime.Reference {
}
}

func TestNewSetProviderReference(t *testing.T) {
want := `package pkg

import runtime "example.org/runtime"

/*
SetProviderReference of this Type.
Deprecated: Use SetProviderConfigReference.
*/
func (t *Type) SetProviderReference(r *runtime.Reference) {
t.Spec.ProviderReference = r
}
`
f := jen.NewFilePath("pkg")
NewSetProviderReference("t", "example.org/runtime")(f, MockObject{Named: "Type"})
if diff := cmp.Diff(want, fmt.Sprintf("%#v", f)); diff != "" {
t.Errorf("NewSetProviderReference(): -want, +got\n%s", diff)
}
}

func TestNewGetProviderReference(t *testing.T) {
want := `package pkg

import runtime "example.org/runtime"

/*
GetProviderReference of this Type.
Deprecated: Use GetProviderConfigReference.
*/
func (t *Type) GetProviderReference() *runtime.Reference {
return t.Spec.ProviderReference
}
`
f := jen.NewFilePath("pkg")
NewGetProviderReference("t", "example.org/runtime")(f, MockObject{Named: "Type"})
if diff := cmp.Diff(want, fmt.Sprintf("%#v", f)); diff != "" {
t.Errorf("NewGetProviderReference(): -want, +got\n%s", diff)
}
}

func TestNewSetWriteConnectionSecretToReference(t *testing.T) {
want := `package pkg

Expand Down