Skip to content

fix(xr): add missing import, caused by merge of outdated base tree#103

Merged
tampakrap merged 1 commit into
crossplane:mainfrom
tampakrap:theo/fix_missing_import
Jun 12, 2026
Merged

fix(xr): add missing import, caused by merge of outdated base tree#103
tampakrap merged 1 commit into
crossplane:mainfrom
tampakrap:theo/fix_missing_import

Conversation

@tampakrap

@tampakrap tampakrap commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Description of your changes

The title says it all

I have:

Need help with this checklist? See the cheat sheet.

Signed-off-by: Theo Chatzimichos <tampakrap@gmail.com>
@tampakrap tampakrap requested review from a team and jcogilvie as code owners June 12, 2026 14:02
@tampakrap tampakrap requested review from adamwg and haarchri and removed request for a team June 12, 2026 14:02
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

A single import statement is added to cmd/crossplane/render/xr/cmd.go to include the xcrd package from crossplane-runtime, enabling access to xcrd.AnnotationKeyCompositionResourceName for the existing YAML sorting logic.

Changes

XCrd Package Integration

Layer / File(s) Summary
XCrd package import
cmd/crossplane/render/xr/cmd.go
Import of github.com/crossplane/crossplane-runtime/v2/pkg/xcrd is added to satisfy references to xcrd.AnnotationKeyCompositionResourceName used in the render command's sorting logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • crossplane/cli#83: Both PRs modify cmd/crossplane/render/xr/cmd.go to use xcrd.AnnotationKeyCompositionResourceName for handling composed-resource YAML ordering.

Suggested reviewers

  • jcogilvie
🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the change: adding a missing import to fix an issue caused by merging an outdated base tree, and it stays within the 72-character limit.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Breaking Changes ✅ Passed PR #103 only adds an import in cmd/crossplane/render/xr/cmd.go (+1/-0); no apis/** or cmd/** public fields/flags are removed/renamed/added, nor behavior removed.
Feature Gate Requirement ✅ Passed PR adds only the missing xcrd import in cmd/crossplane/render/xr/cmd.go; no new experimental/API behavior or feature-gated functionality is introduced.
Description check ✅ Passed The PR description relates to the changeset - it addresses a missing import issue caused by a merge conflict, which aligns with the code change adding the xcrd import.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tampakrap tampakrap merged commit 1cfeb97 into crossplane:main Jun 12, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants