Feature/add-revoke-logic-to-grant-and-schema#200
Closed
olikyr wants to merge 5 commits into
Closed
Conversation
added 3 commits
December 20, 2024 21:50
…n tests by adding tests for postgresql functionalities Signed-off-by: oliver.zokra <oliver.zokra@kyriba.com>
… Schema resource isPrivate Signed-off-by: oliver.zokra <oliver.zokra@kyriba.com>
Signed-off-by: oliver.zokra <oliver.zokra@kyriba.com>
4b26654 to
9a8bf83
Compare
added 2 commits
December 28, 2024 11:31
update postgresql version in integration tests Signed-off-by: oliver.zokra <oliver.zokra@kyriba.com>
… enhancements on those tests Signed-off-by: oliver.zokra <oliver.zokra@kyriba.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
revokePublicOnDbin grant resource; if true, it will revoke from public access to DB; This usually a DBA requirement.isPrivatein schema resource; if true, it will revoke from public access to a schema; This usually a DBA requirement.Fixes #189
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
I added extensive e2e testing for postgres resources. Privileges are tested by accessing the database created in the cluster and making sql requests.
to push:
Everything is working as expected.