Skip to content

Feature/add-revoke-logic-to-grant-and-schema#200

Closed
olikyr wants to merge 5 commits into
crossplane-contrib:masterfrom
kyriba:feature/add-revoke-logic-to-grant
Closed

Feature/add-revoke-logic-to-grant-and-schema#200
olikyr wants to merge 5 commits into
crossplane-contrib:masterfrom
kyriba:feature/add-revoke-logic-to-grant

Conversation

@olikyr

@olikyr olikyr commented Nov 14, 2024

Copy link
Copy Markdown

Description of your changes

  1. I added a field called revokePublicOnDb in grant resource; if true, it will revoke from public access to DB; This usually a DBA requirement.
  2. I added a field called isPrivate in schema resource; if true, it will revoke from public access to a schema; This usually a DBA requirement.
  3. I splitted the e2e tests and added tests for postgres resources.

Fixes #189

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

  1. inside the project
make clean
make build
make reviewable
make e2e

I added extensive e2e testing for postgres resources. Privileges are tested by accessing the database created in the cluster and making sql requests.

image image image
  1. outside the project: Pushed built pkg to artifactory and pulled it into a local cluster and submitted claims.

to push:

cd _output/xpkg/linux_amd64
ls ---> provider-sql-v0.0.0-219.g4b26654.xpkg
crossplane xpkg push --package-files="provider-sql-v0.0.0-219.g4b26654.xpkg" my-artifactory/providers/provider-sql:0.1.1

Everything is working as expected.

@olikyr olikyr changed the title Feature/add revoke logic to grant Feature/add-revoke-logic-to-grant-and-schema Nov 14, 2024
oliver.zokra added 3 commits December 20, 2024 21:50
…n tests by adding tests for postgresql functionalities

Signed-off-by: oliver.zokra <oliver.zokra@kyriba.com>
… Schema resource isPrivate

Signed-off-by: oliver.zokra <oliver.zokra@kyriba.com>
Signed-off-by: oliver.zokra <oliver.zokra@kyriba.com>
@olikyr olikyr force-pushed the feature/add-revoke-logic-to-grant branch from 4b26654 to 9a8bf83 Compare December 21, 2024 12:01
oliver.zokra added 2 commits December 28, 2024 11:31
update postgresql version in integration tests

Signed-off-by: oliver.zokra <oliver.zokra@kyriba.com>
… enhancements on those tests

Signed-off-by: oliver.zokra <oliver.zokra@kyriba.com>
@olikyr olikyr mentioned this pull request Jan 7, 2025
2 tasks
@olikyr olikyr closed this Jan 16, 2025
@olikyr olikyr deleted the feature/add-revoke-logic-to-grant branch January 16, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply "revoke all on database mydb from public;" after creating mydb - In general, we need revoke functionalities (Revoke resource).

1 participant