Fix/Grant update failed: not allowed to create a user with grant#129
Closed
alereca wants to merge 4 commits into
Closed
Fix/Grant update failed: not allowed to create a user with grant#129alereca wants to merge 4 commits into
alereca wants to merge 4 commits into
Conversation
Signed-off-by: Alejandro Recalde <alejandro.recalde@avature.net>
Signed-off-by: Alejandro Recalde <alejandro.recalde@avature.net>
…st of grant controller code Signed-off-by: Alejandro Recalde <alejandro.recalde@avature.net>
Duologic
approved these changes
Aug 9, 2023
Member
|
A rebase should re-trigger CI. sorry for the late responses to your PRs, I had other priorities |
Contributor
Author
No problem, thanks for reviewing them! I've just merged master to fix the conflicts if you would like to check it and merge it later. I forgot to sign-off so I had to perform a force push, consequently all checks got blocked again |
Signed-off-by: Alejandro Recalde <alejandro.recalde@avature.net>
alereca
force-pushed
the
fix/not-allowed-to-create-a-user-with-grant
branch
from
eeefd6b to
3d7fdb9
Compare
Member
|
I was looking at rebasing this but fail to see what's being fixed, for now I only see variable names being changed. I get that there is an inconsistency but don't see an actual bug, so maybe I'm missing something? |
Member
|
I've made an attempt at incorporating the proposed changes in this PR: #205 |
artych
approved these changes
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #127
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
./cluster/local/integration_tests.shto test this scenario, since unit tests do not seem to be a good fit for this