feat(cloudfront): Add OriginalAccessControl controller #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbcjorge
force-pushed
the
feature/cloudfront_originaccesscontrol
branch
from
a0b54f4
to
8b9a392
Compare
Signed-off-by: Jorge Millán <jbcjorge@gmail.com> This adds the missing CloudFront:OriginAccessControl type, most of the changes are autogenerated except the `originaccesscontrol/setup.go` file in the CloudFront controller. It validates additionally the specific enums for the `OriginType`, `SigningBehavior` and `SigningProtocol` as well as the length of the name of the AWS resource
Signed-off-by: Jorge Millán <jbcjorge@gmail.com>
jbcjorge
force-pushed
the
feature/cloudfront_originaccesscontrol
branch
from
9defd43
to
589ad2c
Compare
Signed-off-by: Jorge Millán <jbcjorge@gmail.com>
jbcjorge
force-pushed
the
feature/cloudfront_originaccesscontrol
branch
from
39818ee
to
a2f5f4c
Compare
Signed-off-by: Jorge Millán <jbcjorge@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This adds the missing CloudFront:OriginAccessControl type, most of the changes are autogenerated except the
originaccesscontrol/setup.gofile in the CloudFront controller.It validates additionally the specific enums for the
OriginType,SigningBehaviorandSigningProtocolas well as the length of the name of the AWS resourceI have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested in a productive environment: