Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eks): Updating of subnetIds and securityGroupdIds #2107

Merged

Conversation

simwak
Copy link
Contributor

@simwak simwak commented Oct 18, 2024

Description of your changes

Add the functionality to update the subnetIds and securityGroupdIds

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • Created a cluster and updated subnetIds and securityGroupdIds
  • Unit tests

Signed-off-by: Simon Wakenhut <simon@simonwakenhut.me>
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @simwak!

@MisterMX MisterMX merged commit 59d66d3 into crossplane-contrib:master Oct 18, 2024
9 checks passed
Copy link

Successfully created backport PR #2109 for release-0.50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants