ec2: include attributes in instance observation, fix reconciling tags #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that when tags change, the EC2 instance reconciles the update. Previously the ec2 instance controller supported updating tags via `CreateTags` but did not perform reconciliation when tags changed as it was not included in the check for if the EC2 instance was up to date. However, the way `Update` is currently implemented had the implicit assumption that the EC2 instance must be stopped for all updates, which is true for all the ModifyInstanceAttribute calls, however, tags can be applied at runtime. This changes the logic of the controller to (1) include the instance attributes in the instance observations, (2) only attempt to modify instance attributes if the observation does not match the spec. Signed-off-by: justin.miron <justin.miron@reddit.com>
MisterMX
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This ensures that when tags change, the EC2 instance reconciles the update. Previously the ec2 instance controller supported updating tags via
CreateTagsbut did not perform reconciliation when tags changed as it was not included in the check for if the EC2 instance was up to date.However, the way
Updateis currently implemented had the implicit assumption that the EC2 instance must be stopped for all updates, which is true for all the ModifyInstanceAttribute calls, however, tags can be applied at runtime. This changes the logic of the controller to (1) include the instance attributes in the instance observations, (2) only attempt to modify instance attributes if the observation does not match the spec.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
This code has been tested on and deployed in our own fork used in production.
Unit tests are updated to include instance attributes.