ec2: Create security group with tags in the spec #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resource tags are used to ensure that only IAM roles with the right access can modify the resources. This ensures that the security groups will have the right tags from creation time. Without this change, IAM policy based on tags may fail to run subsequent steps of security group creation. Signed-off-by: justin.miron <justin.miron@reddit.com>
MisterMX
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Resource tags are used to ensure that only IAM roles with the right access can modify the resources. This ensures that the security groups will have the right tags from creation time. Without this change, IAM policy based on tags may fail to run subsequent steps of security group creation.
This change makes security groups created with the tags rather than waiting for the first observation / update to add tags.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested on our own internal production fork and staging environments.