Add support for operation function output #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negz
commented
Jul 11, 2025
go.mod
Outdated
| go 1.24 | ||
|
|
||
| toolchain go1.21.3 | ||
| replace github.com/crossplane/function-sdk-go => github.com/negz/function-sdk-go v0.0.0-20250711051713-67cc65c5665e |
Member
Author
There was a problem hiding this comment.
Depends on crossplane/function-sdk-go#212.
Need to release that and remove this before merging.
(This is also what the linter's upset about.)
Member
There was a problem hiding this comment.
don't forget to remove this replace statement 😉
7 tasks
jbw976
approved these changes
Jul 15, 2025
go.mod
Outdated
| go 1.24 | ||
|
|
||
| toolchain go1.21.3 | ||
| replace github.com/crossplane/function-sdk-go => github.com/negz/function-sdk-go v0.0.0-20250711051713-67cc65c5665e |
Member
There was a problem hiding this comment.
don't forget to remove this replace statement 😉
I need this to E2E test operation functions in Crossplane. This'll also be a breaking change for users of this function, since the SDK renames extra_resources to required_resources. Signed-off-by: Nic Cope <nicc@rk0n.org>
Signed-off-by: Nic Cope <nicc@rk0n.org>
Forgot to bump versions in ci.yaml Also port linter config to v2, run it. Signed-off-by: Nic Cope <nicc@rk0n.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need this to E2E test operation functions in Crossplane.
This'll also be a breaking change for users of this function, since the SDK renames extra_resources to required_resources. I'm not worried about that - I doubt this is used outside of testing.