Skip to content

feat: add customizable grpc max size#372

Draft
fernandezcuesta wants to merge 3 commits into
crossplane-contrib:mainfrom
fernandezcuesta:368--set-fn-gotpl-max-grpc-size
Draft

feat: add customizable grpc max size#372
fernandezcuesta wants to merge 3 commits into
crossplane-contrib:mainfrom
fernandezcuesta:368--set-fn-gotpl-max-grpc-size

Conversation

@fernandezcuesta

@fernandezcuesta fernandezcuesta commented Jul 9, 2026

Copy link
Copy Markdown

Description of your changes

Fixes #368

I have:

  • Read and followed Crossplane's contribution process.
  • Run earthly -P +reviewable to ensure this PR is ready for review.
  • Added or updated unit tests.
  • Added or updated e2e tests.
  • Documented this change as needed.
  • Followed the API promotion workflow if this PR introduces, removes, or promotes an API.

Need help with this checklist? See the cheat sheet.

Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
@fernandezcuesta fernandezcuesta force-pushed the 368--set-fn-gotpl-max-grpc-size branch from c0cbb75 to 592e5f7 Compare July 9, 2026 16:32
Comment thread cmd/diff/cmd_utils.go Outdated
return flag
}

if v := os.Getenv(envMaxRecvMessageSize); v != "" {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kong natively supports an env struct tag in the input object, so you can use that instead of hand-rolling this.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, changed

Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
@fernandezcuesta fernandezcuesta force-pushed the 368--set-fn-gotpl-max-grpc-size branch 2 times, most recently from a404aee to 55461c2 Compare July 10, 2026 07:54
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
@fernandezcuesta fernandezcuesta force-pushed the 368--set-fn-gotpl-max-grpc-size branch from 55461c2 to ced79e2 Compare July 10, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crossplane-diff fails with too large composites relying on function-go-templating

2 participants