Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some publish warnings #503

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Conversation

legnes
Copy link
Contributor

@legnes legnes commented Apr 29, 2024

This PR adds some new warnings on publish, concerning word length, unches, references, and enumerations.

image

Closes #495

Copy link
Member

@mdirolf mdirolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Two questions - one minor one about the enum parser and one that I think needs a change w/r/t when we set enumsExpected

@@ -65,6 +65,10 @@ export enum Direction {
Down,
}

export function directionString(dir: Direction): string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this refactoring!

app/lib/parse.ts Show resolved Hide resolved
app/reducers/builderUtils.ts Outdated Show resolved Hide resolved
@mdirolf
Copy link
Member

mdirolf commented Apr 29, 2024

Thank you for tackling this one!

@mdirolf mdirolf merged commit b65cbc4 into crosshare-org:master Apr 30, 2024
1 check passed
@legnes legnes deleted the enum-ref-warnings branch April 30, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some more publish warnings
2 participants