-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some publish warnings #503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! Two questions - one minor one about the enum parser and one that I think needs a change w/r/t when we set enumsExpected
@@ -65,6 +65,10 @@ export enum Direction { | |||
Down, | |||
} | |||
|
|||
export function directionString(dir: Direction): string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this refactoring!
Thank you for tackling this one! |
becacfe
to
8fd9ee4
Compare
This PR adds some new warnings on publish, concerning word length, unches, references, and enumerations.
Closes #495