Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't steal from the same deque #448

Merged
merged 2 commits into from Jan 17, 2020
Merged

Don't steal from the same deque #448

merged 2 commits into from Jan 17, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 10, 2019

This PR checks whether the source and destination deque are the same when stealing tasks. If so, we return from the function early.

@taiki-e taiki-e mentioned this pull request Nov 20, 2019
Merged
bors bot added a commit that referenced this pull request Nov 20, 2019
@bors @taiki-e
Merge #450
424f926 
450: Format with rustfmt r=stjepang a=taiki-e

This fix build failure in #449 and #448

It seems old rustfmt did not properly format the module in the macro.

Co-authored-by: Taiki Endo <te316e89@gmail.com>
@ghost
Copy link
Author

ghost commented Jan 17, 2020

bors r+

bors bot added a commit that referenced this pull request Jan 17, 2020
@bors
Merge #448
ef372be 
448: Don't steal from the same deque r=stjepang a=stjepang

This PR checks whether the source and destination deque are the same when stealing tasks. If so, we return from the function early.

Co-authored-by: Stjepan Glavina <stjepang@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 17, 2020

Build succeeded

@bors bors bot merged commit 131ff9a into crossbeam-rs:master Jan 17, 2020
@ghost ghost deleted the dont-steal-from-same-worker branch January 19, 2020 19:51
exrook pushed a commit to exrook/crossbeam that referenced this pull request Oct 7, 2020
@flxo @froydnj
Fix windows build by indicating anonymous lifetimes (crossbeam-rs#448)
e516d90 
Along with the missing explicit lifetimes a couple or warnings
regarding duplicate use directives are fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants