Repository navigation
Fix 1938 - #1939
Merged
Merged
Fix 1938#1939
Conversation
Delete three pieces of pre-existing dead code that ty (floated on the bleeding edge) flagged on the CI run for crossbario#1937, rather than growing the ty-ignore list: - src/autobahn/asyncio/component.py: unused private helper _unique_list (no call sites anywhere in the repo). - src/autobahn/twisted/component.py: identical unused _unique_list. - src/autobahn/websocket/protocol.py: the `if response_body:` block in the server opening handshake was unreachable - response_body is hard-set to None and never reassigned, and a 101 Switching Protocols response carries no body. Removed the block and the dead assignment. Pure deletion (24 lines); all private/unreachable, no public API change. Verified locally: check-typing clean (ruff + ty, all checks passed); Twisted 357 tests PASSED (325 successes, 32 skips); asyncio 275 passed, 0 failures. Handshake output is unchanged (the removed block never ran). Full wstest compliance + Crossbar smoke run in CI. Note: This work was completed with AI assistance (Claude Code).
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1938