-
Notifications
You must be signed in to change notification settings - Fork 771
fix twisted 22.10.0 incompability #1604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ec64fe7
to
ffe679f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this causes a slight, and probably inconsequential, change in the error page content:
Previously, NoResource("No such child resource.")
called _UnsafeErrorPage(brief="No Such Resource", detail="No such child resource.")
.
Now, notFound("No such child resource.")
calls _ErrorPage(brief="No such child resource.", detail="Sorry. No luck finding that resource.")
.
ffe679f
to
84f00ec
Compare
@@ -100,7 +105,7 @@ def getChildWithDefault(self, name, request): | |||
""" | |||
This resource cannot have children, hence this will always fail. | |||
""" | |||
return NoResource("No such child resource.") | |||
return notFound(message="No such child resource.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now both and old code should be better aligned...
thanks for contributing! fwiw, I think the check CI step is failing due no a regression with CPy 311 - which the check step seems to use - and this is unrelated to the PR here (which looks good btw) seems to be a thing a couple of project run into, google for "cannot import name 'getargspec' from 'inspect'" .. I haven't dug further, but likely some import needs a fix, or the check CI step should use a fixed CPy, not CPy 3.x ... |
the failing 2 steps (check and docs) in https://github.com/crossbario/autobahn-python/blob/master/.github/workflows/main.yml are failing since the steps use "open ended" python version
which runs into issues unrelated to the PR. we might change those 2 location from "3.x" to "3.10". and we should also expand
to with those changes to main.yaml, this PR should run fully green and could be merged
|
done. |
alright, thanks, that "fixed" (circumvents) the problem on check/docs step. unfortunately, the enabling of 3.11 for the main tests uncovers another issue:
other project are running into this as well cython/cython#4428 googling for "twisted python 3.11 longintrepr.h" doesn't seem to return anything specific twisted related, so this might be a new twisted issue (on 3.11) obviously, this is unrelated to this PR, and hence, you could change this PR again back to as a consequence: we can't bump autobahn to fully support py 3.11, at least because of the remaining twisted issue .. sorry for the hassles! OSS maintenance real-world;) |
No description provided.