-
Notifications
You must be signed in to change notification settings - Fork 771
Open
Description
Summary
During the modernization to the new justfile/uv-based build system, several files from the old CI/CD infrastructure were left behind. These files are no longer referenced by any workflow or build process and should be removed to reduce confusion and maintenance burden.
Orphaned Files
Root Directory Files
| File | Description | Evidence |
|---|---|---|
Makefile.orig |
Old makefile | Replaced by justfile. References old paths like ./autobahn/_version.py (before src/ layout) |
Dockerfile.wheels |
Docker wheel builder | Not used by any workflow. wheels-docker.yml uses container images directly via container: directive |
mypy.ini |
Mypy configuration | Not referenced in justfile or any workflow. Mypy is not used |
test-docker-builds.sh |
Local Docker testing | References non-existent docker-bake.hcl. Not used in any workflow |
versions.sh |
Build environment vars | Uses old path ./autobahn/_version.py. Only referenced by orphaned docker/README.md |
deploy.sh |
S3 deployment script | Old deployment to crossbarbuilder.s3.eu-central-1.amazonaws.com. Calls office2dmz.crossbario.com webhook |
.prettierrc.json |
Prettier config | Only referenced in Makefile.orig (line 194) which is also orphaned |
.coveragerc |
Coverage config | Minimal config (just omits test files). Coverage commands in justfile use explicit --source= flags |
Orphaned Documentation
| File | Issue |
|---|---|
docs/DOCKER_BUILDS.md |
References non-existent docker-bake.hcl and orphaned files (Dockerfile.wheels, test-docker-builds.sh) |
docker/README.md |
References versions.sh and non-existent .github/workflows/docker.yml workflow |
PyInstaller Directory
| Path | Issue |
|---|---|
pyinstaller/hook-autobahn.py |
PyInstaller hook for autobahn |
pyinstaller/hook-twisted.py |
PyInstaller hook for twisted |
The README.md already states:
no longer explicitly supports PyInstaller packaging
PyInstaller is still listed as a dev dependency in pyproject.toml, but this can be removed along with the hooks.
Verification
All files were checked against:
.github/workflows/*.yml- No references foundjustfile- No references foundpyproject.toml- No references found (exceptmypy_cacheexclusion in gitignore)
Verification commands:
# Check for references in workflows
grep -r "Makefile.orig\|Dockerfile.wheels\|mypy.ini\|test-docker-builds\|versions.sh\|deploy.sh\|prettierrc\|coveragerc" .github/workflows/
# Check for references in justfile
grep -E "Makefile.orig|Dockerfile.wheels|mypy.ini|test-docker-builds|versions.sh|deploy.sh|prettierrc|coveragerc" justfile
# Check pyinstaller references
grep -r "pyinstaller" .github/workflows/ justfileFiles to Delete
Root directory:
Makefile.orig
Dockerfile.wheels
mypy.ini
test-docker-builds.sh
versions.sh
deploy.sh
.prettierrc.json
.coveragerc
Documentation:
docs/DOCKER_BUILDS.md
docker/README.md
PyInstaller:
pyinstaller/hook-autobahn.py
pyinstaller/hook-twisted.py
pyinstaller/ (entire directory)
Remove from pyproject.toml:
# Remove from dev dependencies:
"pyinstaller>=4.2",Impact
- No functional impact - files are not used by any workflow or build process
- Reduces repository clutter
- Prevents confusion for contributors
- Removes stale/misleading documentation
- Drops unused dev dependency (
pyinstaller)
TODO
- Delete root directory orphaned files (8 files)
- Delete
docs/DOCKER_BUILDS.md - Delete
docker/README.md - Delete
pyinstaller/directory - Remove
pyinstaller>=4.2frompyproject.tomldev dependencies - Regenerate
uv.lockafter removing pyinstaller dependency - Update changelog
Checklist
- I have searched existing issues to avoid duplicates
- I have provided a minimal reproducible example
- I have included version information
- I have included error messages/logs