[Feature] Make incoming message size configurable

[om26er]

I am not sure about the websocket implementation but when using twisted RawSocket transport, if the incoming message size is greater than 100kb, my connection drops. We basically need an option to configure the incoming message size of the underlying transport.

For twisted its Int32StringReceiver.MAX_SIZE that we need to set.

[meejah]

Clarification: protocol_instance.MAX_LENGTH (see https://github.com/twisted/twisted/blob/trunk/src/twisted/protocols/basic.py#L70)

[oberstet]

fwiw, crossbar has that here:

• https://github.com/crossbario/crossbar/blob/d4b21fc66a03237b9c06b64547db80caf0eaf9a6/crossbar/router/protocol.py#L625
• https://twistedmatrix.com/documents/current/api/twisted.protocols.basic.Int32StringReceiver.html

[meejah]

Hmm, so there's nothing to do here then? (i.e. it looks like passing "max_message_size" in the config of a rawsocket will work?)

[oberstet]

What I'm sure is that CB has a configuration knob (max_message_size) for receiving leg max message size.

What I'm not sure is CB on the rawsocket sending side: does it honor the negotiated side and deny sending such as message to a peer?

I am also not sure about the client side: a rawsocket client should have similar knobs. As in: an AB rawsocket client connecting to a remote CB. And that client side is also used in CB - eg when a container is hooked up to a router on the same node.

And finally: should anyone want to implement an own (non-CB) rawsocket server, the knob that we have in CB .. is in CB, no AB.

A slight mess / gaps I'd say .. btw: this stuff could be related to a bug recently filed by @oddjobz on CB/CFX when a mrealm container (which talk rawsocket via UDS) dies .. not sure though

[oberstet]

see also #922