Support MSVC/Windows

[oberstet]

[solarisx]

Hi

I like the autobahn websocket very much and use the autobahn.js in a tiny project. But unfortunalety I need it in a MSVC project.
So, despite my slight knowledge in c++ and boost, I make a try in helping to solve this issue.

First step, the examples need the #define WIN32_LEAN_AND_MEAN makro.

In autobahn_impl.hpp

#ifdef WIN32
#include <WinSock2.h>
#include <io.h>
#else
#include <arpa/inet.h>
#include <unistd.h>
#endif

will help.

But now i stuck on this:
error C2280: 'boost::promise<boost::any> &boost::promise<boost::any>::operator =(const boost::promise<boost::any> &)' : attempting to reference a deleted function

Maybe someone can help out.

Greets

[oberstet]

@solarisx What environment are you using? Compiler version, Boost version, etc

[solarisx]

Visual C++ 2013 with 18.00.30723 Compiler on Win7 x64.
I get the boost error with boost versions 1_56 and 1_57. With boost 1_55 there are some more.

[DominickT]

I am having the exact same error with the same setup as solarisx.

[oberstet]

@DominickT sorry, I don't use Windows/VC++ nowerdays and won't have time to do so soon.

You might have a look at

http://stackoverflow.com/questions/24921149/error-c2280-attempting-to-reference-a-deleted-function-trying-to-call-vector-e

and/or ask on Boost mailing lists. Probabyl boost::promise lacks something or needs something defined on Windows to work ...

[codeandroid]

I managed to port it to Visual C++ 2012 (vc110) and boost 1.56.0. I did not try Visual C++ 2013 (vc120).

It wasn't that bad - mostly took some configuration (boost defines) and converting boost::future to boost:shared_future, and adding .share() to future<>.then(...) in a few places. There seems to be an issue when copying/moving a boost::future with msvc ...

As I only need it for a prototype for now, I haven't run tests but the basics seem to work: binding rpc methods, calling them via html+js through a crossbar instance.

I don't plan to maintain this port - but may be able to make it available on request.

[krasi0]

After a big battle, I managed to get it to compile and run (Windows 7 / VS 2013 / VC120).

Apart from following the advice above, a patch was needed inside Boost future.hpp:
BOOST_THREAD_COPYABLE_AND_MOVABLE(promise) instead of
BOOST_THREAD_MOVABLE_ONLY(promise).

If the above change is not made, autobahn_impl.hpp doesn't compile due to this operation:
m_register_requests[m_request_id] = register_request_t(endpoint);

Unfortunately running it doesn't produce the expected results. The socket connection succeeds but the client never enters the specified realm.

This is the whole output with debug mode enabled, when running the call1.cpp example:

---

Running on 105700
Starting ASIO I/O loop ..
Connected to server
RX preparing to receive message ..
TX message (56 octets) ...
TX message sent (60 / 60 octets)

---

...and the client remains stuck at this point.

Any advice on how to proceed?
@codeandroid , I would be grateful if you list your exact changes or upload the modified source code somewhere.
Regards

[IvaKom]

See my comment at #27

[krasi0]

@IvaKom , thanks for the tip!
Your addition seems to make perfect sense and I guess a PR would be nice.
I am now able to compile:
https://raw.githubusercontent.com/tavendo/AutobahnCpp/master/examples/register2.cpp
But the call 1 example is still failing: https://github.com/tavendo/AutobahnCpp/blob/master/examples/call1.cpp

---

Anyhow, more importantly, my C++ client never joins the realm ("realm1" in my case).
Basically the body of the closure below is never executed:

---

session_future = session.join("realm1").then([&](shared_future<uint64_t> s) {
cerr << "Session joined to realm with session ID " << s.get() << endl;
// ....
});

---

OTOH, the nodejs and browser based clients successfully manage to connect and perform RPC calls, etc.

---

I have followed the other advice on this thread:

1. Adding #define WIN32_LEAN_AND_MEAN (although I don't think that it makes much of a difference in this case)
2. Renamed the ERROR = 8, of enum class msg_code to something else.
3. Added surrounding defines around case msgpack::type::DOUBLE:, as it's not defined in the VS 2013 case
4. Replaced all future to shared_future and appended .share() to .then(...)
5. Reordered the #include <boost/asio.hpp> & #include <boost/version.hpp> includes, due to a WinSock check.

Still, the C++ client never enters the specified realm. What am I still missing?

Thanks in advance!

[IvaKom]

I'll try to come up with a clean PR.
On Feb 21, 2015 3:04 AM, "krasi0" notifications@github.com wrote:

@IvaKom https://github.com/IvaKom , thanks for the tip!
Your addition seems to make perfect sense and I guess a PR would be nice.
I am now able to compile:

https://raw.githubusercontent.com/tavendo/AutobahnCpp/master/examples/register2.cpp
But the call 1 example is still failing:

https://github.com/tavendo/AutobahnCpp/blob/master/examples/call1.cpp

Anyhow, more importantly, my C++ client never joins the realm ("realm1" in
my case).

Basically the body of the closure below is never executed:

session_future = session.join("realm1").then(& {
cerr << "Session joined to realm with session ID " << s.get() << endl;
// ....

});

OTOH, the nodejs and browser based clients successfully manage to connect

and perform RPC calls, etc.

I have followed the other advice on this thread:

1. Adding #define WIN32_LEAN_AND_MEAN (although I don't think that it
   makes much of a difference in this case)
2. Renamed the ERROR = 8, of enum class msg_code to something else.
3. Added surrounding defines around case msgpack::type::DOUBLE:, as it's
   not defined in the VS 2013 case
4. Replaced all future to shared_future and appended .share() to .then(...)
5. Reordered the #include & #include includes, due to a WinSock check.

Still, the C++ client never enters the specified realm. What am I still
missing?

Thanks in advance!

—
Reply to this email directly or view it on GitHub
#2 (comment).

[IvaKom]

I've created a pull request, see #28.

[krasi0]

Thanks!
With the changes from your PR, the aforementioned "Register 2" example compiles and runs (never enters the realm, so no improvement there). "Call 1" still doesn't compile.

After you compile and run it, are you able to join the realm of a crossbar server? I have tried with an instance running over the network, as well as against demo.crossbar.io, but to no avail.

[lkoelman]

@IvaKom Thanks for your patch, everything compiles fine here too. However, I can confirm @krasi0 's problem of being unable to enter the realm. At least my callback lambda function in the then-clause never executes.

[krasi0]

Exactly. That is the most profound issue - not being able to join the
realm...
I wonder if it has something to do with the lack of specifying /ws as a
part of the URL. In all other languages, the full URL is specified. In C++,
only the IP and port. What do you guys think?
On Feb 22, 2015 5:57 PM, "mananatee" notifications@github.com wrote:

@IvaKom https://github.com/IvaKom Thanks for your patch, everything
compiles fine here too. However, I can confirm @krasi0
https://github.com/krasi0 's problem of being unable to enter the
realm. At least my callback lambda function in the then-clause never
executes.

—
Reply to this email directly or view it on GitHub
#2 (comment).