-
Notifications
You must be signed in to change notification settings - Fork 411
replace walkdir with ripgreps ignore crate #941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
Build failed: |
oops, we might want to pin a start and end on the bisect test. I've been toying with doing an actual useful bisect so that rustc forge artifacts are used as well but for now --start and --end will work fine. |
0dd1f90 doesn't work, need to find another solution (like actually doing a bisect) |
It might be worth actually keeping the range though: we don't need to go to nightly builds in 2017. |
this needs to be fixed more permanently in a separate pr
bors retry |
Build failed: |
Error is rustup during self-update, as reported on reddit will probably file an issue
|
unable to reproduce in a new repo: https://github.com/Emilgardis/rustup-windows-issue/runs/7297777595?check_suite_focus=true it also worked in the test run https://github.com/cross-rs/cross/runs/7296868185?check_suite_focus=true#step:3:85 lets try windows specifically bors try --target x86_64-pc-windows-msvc |
it works, lets try again bors try- bors r=@Alexhuszagh |
it failed again, might be a concurrency issue, unsure how the windows virtual environment works for this. Will bypass with bors cancel |
Canceled. |
bors r+ |
Build succeeded: |
No description provided.