Skip to content

replace walkdir with ripgreps ignore crate #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

Emilgardis
Copy link
Member

No description provided.

@Emilgardis Emilgardis requested a review from a team as a code owner July 11, 2022 21:16
@Emilgardis Emilgardis added no changelog A valid PR without changelog (no-changelog) labels Jul 11, 2022
Copy link
Contributor

@Alexhuszagh Alexhuszagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jul 11, 2022
941: replace walkdir with ripgreps ignore crate r=Alexhuszagh a=Emilgardis



Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 11, 2022

Build failed:

@Emilgardis
Copy link
Member Author

oops, we might want to pin a start and end on the bisect test. I've been toying with doing an actual useful bisect so that rustc forge artifacts are used as well but for now --start and --end will work fine.

@Emilgardis
Copy link
Member Author

0dd1f90 doesn't work, need to find another solution (like actually doing a bisect)

@Alexhuszagh
Copy link
Contributor

It might be worth actually keeping the range though: we don't need to go to nightly builds in 2017.

this needs to be fixed more permanently in a separate pr
@Emilgardis
Copy link
Member Author

bors retry

bors bot added a commit that referenced this pull request Jul 12, 2022
941: replace walkdir with ripgreps ignore crate r=Alexhuszagh a=Emilgardis



Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 12, 2022

Build failed:

@Emilgardis
Copy link
Member Author

Emilgardis commented Jul 12, 2022

Error is rustup during self-update, as reported on reddit

will probably file an issue

rustup 1.24.3 (ce5817a94 2021-05-31)info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.61.0 (fe5b13d68 2022-05-18)`
Installed rustup 1.24.3 support profiles
C:\Users\runneradmin\.cargo\bin\rustup.exe set profile minimal
info: profile set to 'minimal'
C:\Users\runneradmin\.cargo\bin\rustup.exe toolchain install stable
info: syncing channel updates for 'stable-x86_64-pc-windows-msvc'
info: latest update on 2022-06-30, rust version 1.62.0 (a8314ef7d 2022-06-27)
info: downloading component 'clippy'
info: downloading component 'rustfmt'
info: downloading component 'rust-std' for 'i686-pc-windows-msvc'
info: downloading component 'cargo'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: removing previous version of component 'clippy'
info: removing previous version of component 'rustfmt'
info: removing previous version of component 'rust-std' for 'i686-pc-windows-msvc'
info: removing previous version of component 'cargo'
info: removing previous version of component 'rust-std'
info: removing previous version of component 'rustc'
info: installing component 'clippy'
info: installing component 'rustfmt'
info: installing component 'rust-std' for 'i686-pc-windows-msvc'
info: installing component 'cargo'
info: installing component 'rust-std'
info: installing component 'rustc'
  stable-x86_64-pc-windows-msvc updated - rustc 1.62.0 (a8314ef7d 2022-06-27) (from rustc 1.61.0 (fe5b13d68 2022-05-18))
info: checking for self-updates
info: downloading self-update
error: could not copy file from 'C:\Users\runneradmin\.cargo\bin\rustup-init.exe' to 'C:\Users\runneradmin\.cargo\bin\rustup.exe': Access is denied. (os error 5)
Unexpected error attempting to determine if executable file exists 'C:\Users\runneradmin\.cargo\bin\rustup.exe': Error: EPERM: operation not permitted, stat 'C:\Users\runneradmin\.cargo\bin\rustup.exe'
Error: Unable to locate executable file: C:\Users\runneradmin\.cargo\bin\rustup.exe. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also verify the file has a valid extension for an executable file.

@Emilgardis
Copy link
Member Author

Emilgardis commented Jul 12, 2022

unable to reproduce in a new repo: https://github.com/Emilgardis/rustup-windows-issue/runs/7297777595?check_suite_focus=true

it also worked in the test run https://github.com/cross-rs/cross/runs/7296868185?check_suite_focus=true#step:3:85

lets try windows specifically

bors try --target x86_64-pc-windows-msvc

bors bot added a commit that referenced this pull request Jul 12, 2022
@Emilgardis
Copy link
Member Author

it works, lets try again

bors try-

bors r=@Alexhuszagh

bors bot added a commit that referenced this pull request Jul 12, 2022
941: replace walkdir with ripgreps ignore crate r=Alexhuszagh a=Emilgardis



Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
@Emilgardis
Copy link
Member Author

it failed again, might be a concurrency issue, unsure how the windows virtual environment works for this. Will bypass with rustup set auto-self-update disable

bors cancel

@bors
Copy link
Contributor

bors bot commented Jul 12, 2022

Canceled.

@Emilgardis Emilgardis requested review from Alexhuszagh and a team July 12, 2022 08:56
@Alexhuszagh
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 12, 2022

Build succeeded:

@bors bors bot merged commit 6cd09b3 into cross-rs:main Jul 12, 2022
@Emilgardis Emilgardis deleted the newlines-pls branch July 12, 2022 16:10
@Emilgardis Emilgardis added this to the v0.3.0 milestone Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants