Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a "SafeCommand" type which Debugs as a shell-escaped String when running build commands inside Docker. #358

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Use a "SafeCommand" type which Debugs as a shell-escaped String when running build commands inside Docker. #358

merged 1 commit into from
Dec 9, 2019

Conversation

iostat
Copy link
Contributor

@iostat iostat commented Dec 9, 2019

Fixes #357

@iostat iostat requested review from Dylan-DPC-zz and a team as code owners December 9, 2019 19:30
@iostat iostat changed the title Use a "SafeCommand" type which Debug's as a shell-escaped String when running build commands inside Docker. Use a "SafeCommand" type which Debugs as a shell-escaped String when running build commands inside Docker. Dec 9, 2019
@reitermarkus
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Dec 9, 2019
@bors @iostat
Merge #358
105a4ae 
358: Use a "SafeCommand" type which `Debug`s as a shell-escaped String when running build commands inside Docker. r=reitermarkus a=iostat

Fixes #357 

Co-authored-by: Ilya Ostrovskiy <iostat@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Dec 9, 2019

Build succeeded

@bors bors bot merged commit 3899c2b into cross-rs:master Dec 9, 2019
@reitermarkus
Copy link
Member

Thanks, @iostat, nice work!

@Amanieu
Copy link

Amanieu commented Dec 11, 2019

Could you release a new version of cross with this fix?

@Amanieu Amanieu mentioned this pull request Dec 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reitermarkus reitermarkus reitermarkus approved these changes

@Dylan-DPC-zz Dylan-DPC-zz Awaiting requested review from Dylan-DPC-zz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error: no such subcommand: cargo
3 participants
@iostat @reitermarkus @Amanieu