Allow writing Cargo.toml in project directory.
#348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reitermarkus
force-pushed
the
project-writable
branch
from
181419d
to
6f8b258
Compare
reitermarkus
force-pushed
the
project-writable
branch
from
6f8b258
to
83778cb
Compare
|
bors try |
tryBuild succeeded
|
|
Would it be possible to instead mount the Cargo.toml file in docker as rw as an alternative? |
|
No, since it's a file. You can only mount directories as a volume. |
therealprof
approved these changes
Nov 16, 2019
I mean there could be another way, but I'm pretty sure it wouldn't be worth the additional complexity for virtually no gain. If this really was a big enough problem, |
I'm pretty certain it's possible in docker. |
You're right, seems like it is indeed possible. Still, this wouldn't work in the case when |
therealprof
approved these changes
Nov 21, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 21, 2019
348: Allow writing `Cargo.toml` in project directory. r=therealprof a=reitermarkus The project directory was previously deliberately mounted as read-only since “well behaved crates should only ever write to `$OUT_DIR` and never modify `$CARGO_MANIFEST_DIR`”. That however, breaks the `--locked` flag and is not worth the additional complexity. Fixes #346. Co-authored-by: Markus Reiter <me@reitermark.us>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project directory was previously deliberately mounted as read-only since “well behaved crates should only ever write to
$OUT_DIRand never modify$CARGO_MANIFEST_DIR”. That however, breaks the--lockedflag and is not worth the additional complexity.Fixes #346.