-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update emscripten to 1.38.46-upstream #335
Conversation
Rust updated its emscripten version again to a version that uses the upstream LLVM wasm backend that the other Rust wasm targets are also using. cross' docker has been updated accordingly: https://github.com/rust-lang/rust/pull/63649/files#diff-3334ef4d3e22f40ded09f2045806021f
Have you looked into the CI failure? |
I don't think I have as I had very little time. But it seems like it can't find the build when trying to access it now. |
Weird, I also can't access it anymore now. |
bors try |
tryBuild failed
|
The failures seem to be: For asmjs: We'll have to dig deeper what they mean. |
Actually I believe the problem could be it using the new emcc but an old Rust compiler (the change is only on nightly). The docker images don't contain the Rust compiler right? So essentially only the tests would need to be updated to use the nightly compiler instead. |
Yes, the compiler is mounted via a volume.
Would this not break using stable Rust then? |
Yeah we should probably release this with 1.40 |
Emscripten has been updated in #361 but the C++ test is failing and has been disabled for now. |
I'm also not planning on using emscripten anymore, so if this PR is still necessary for anyone, feel free to create a new one. |
Rust updated its emscripten version again to a version that uses the upstream LLVM wasm backend that the other Rust wasm targets are also using. cross' docker has been updated accordingly: https://github.com/rust-lang/rust/pull/63649/files#diff-3334ef4d3e22f40ded09f2045806021f