Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update emscripten to 1.38.46-upstream #335

Closed
wants to merge 2 commits into from
Closed

Conversation

CryZe
Copy link
Contributor

@CryZe CryZe commented Oct 6, 2019

Rust updated its emscripten version again to a version that uses the upstream LLVM wasm backend that the other Rust wasm targets are also using. cross' docker has been updated accordingly: https://github.com/rust-lang/rust/pull/63649/files#diff-3334ef4d3e22f40ded09f2045806021f

Rust updated its emscripten version again to a version that uses the upstream LLVM wasm backend that the other Rust wasm targets are also using. cross' docker has been updated accordingly: https://github.com/rust-lang/rust/pull/63649/files#diff-3334ef4d3e22f40ded09f2045806021f
@CryZe CryZe requested review from Dylan-DPC-zz and a team as code owners October 6, 2019 16:19
@reitermarkus
Copy link
Member

Have you looked into the CI failure?

@CryZe
Copy link
Contributor Author

CryZe commented Oct 17, 2019

I don't think I have as I had very little time. But it seems like it can't find the build when trying to access it now.

@reitermarkus
Copy link
Member

Weird, I also can't access it anymore now.

@reitermarkus
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Oct 17, 2019
@bors
Copy link
Contributor

bors bot commented Oct 17, 2019

try

Build failed

  • rust-embedded.cross

@CryZe
Copy link
Contributor Author

CryZe commented Oct 18, 2019

The failures seem to be:

For asmjs: note: shared:ERROR: wasm2js does not support source maps yet (debug in wasm for now)
For wasm32: note: shared:ERROR: BINARYEN_TRAP_MODE is not supported by the LLVM wasm backend

We'll have to dig deeper what they mean.

@CryZe
Copy link
Contributor Author

CryZe commented Oct 18, 2019

Actually I believe the problem could be it using the new emcc but an old Rust compiler (the change is only on nightly).

The docker images don't contain the Rust compiler right? So essentially only the tests would need to be updated to use the nightly compiler instead.

@reitermarkus
Copy link
Member

The docker images don't contain the Rust compiler right?

Yes, the compiler is mounted via a volume.

So essentially only the tests would need to be updated to use the nightly compiler instead.

Would this not break using stable Rust then?

@CryZe
Copy link
Contributor Author

CryZe commented Oct 27, 2019

Yeah we should probably release this with 1.40

@reitermarkus
Copy link
Member

Emscripten has been updated in #361 but the C++ test is failing and has been disabled for now. libstdc++ cannot be found, no idea what the problem is.

@CryZe
Copy link
Contributor Author

CryZe commented Jan 28, 2020

I'm also not planning on using emscripten anymore, so if this PR is still necessary for anyone, feel free to create a new one.

@CryZe CryZe closed this Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants