fix check rustup on default toolchain #1682
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that any cross command is trying to add a rustup toolchain even if is already installed.
I checked that was just checking the
rustup --quiet toolchain list
command and comparing each one, but this check will not work for the active one with(active, default)
.Example:
I needed this fix because setuptools-rust calls cargo/cross metadata and convert it to json, but I was always getting it before the json expected: