Add Solaris targets #138
Merged
Add Solaris targets #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #134.
malbarbo
reviewed
Oct 15, 2017
|
I intend to use Solaris 11 cross compiler here, because that is what is used by most people. I actually only use a hack on the rust repo to have a S10 backward compatible stdlib produced. But it also works for S11 targets and is produced with an illumos sysroot. I think I am the only one using Rust on S10 up to now as I had to change some things to make it work some weeks ago. |
|
Thanks @bgermann. I'll prefer to match the rust repo version (i.e. S10) but if it's not that commonly used then S11 sounds fine. This LGTM. @homunkulus r+ |
|
📌 Commit 02c7b81 has been approved by |
japaric
pushed a commit
that referenced
this pull request
Oct 20, 2017
Add Solaris targets Closes #134.
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134.