Skip to content

Bugfix: use current target_dir path when copying build artifacts back #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2023
Merged

Bugfix: use current target_dir path when copying build artifacts back #1199

merged 2 commits into from
Feb 10, 2023

Conversation

hulucc
Copy link
Contributor

@hulucc hulucc commented Feb 3, 2023

Closes #1103

@hulucc hulucc requested a review from a team as a code owner February 3, 2023 03:42
@Emilgardis
Copy link
Member

bors try --none

bors bot added a commit that referenced this pull request Feb 3, 2023
@bors
Try #1199: --none
a207b6a
@bors
Copy link
Contributor

bors bot commented Feb 3, 2023

try

Build succeeded:

@Emilgardis
Copy link
Member

Emilgardis commented Feb 3, 2023 •
edited
Loading

Does this work when using an absolute target dir?

i.e --target-dir /path/to/my/target/dir or when using a .cargo/config.toml with target dir set?

@Emilgardis Emilgardis changed the title Bugfix: use corrent target_dir path when copying build artifacts back Bugfix: use current target_dir path when copying build artifacts back Feb 3, 2023
@Emilgardis Emilgardis added the no-ci-targets PRs that do not affect or should skip any cross-compilation targets. label Feb 10, 2023
@Emilgardis
Copy link
Member

bors r+

thank you!

@bors
Copy link
Contributor

bors bot commented Feb 10, 2023

Build succeeded:

@bors bors bot merged commit 404ee1f into cross-rs:main Feb 10, 2023
@Emilgardis Emilgardis added this to the v0.3.0 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
no-ci-targets PRs that do not affect or should skip any cross-compilation targets.
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

binaries are not copied back to host with CROSS_REMOTE
2 participants
@hulucc @Emilgardis