Kobo Subtitle configuration option#1375
Open
AsherMaximum wants to merge 10 commits into
Open
Conversation
# Conflicts: # cps/admin.py # cps/config_sql.py # cps/kobo.py # cps/templates/config_edit.html # Conflicts: # cps/admin.py # cps/kobo.py # cps/templates/config_edit.html
# Conflicts: # cps/kobo.py # Conflicts: # cps/kobo.py
# Conflicts: # cps/kobo.py
# Conflicts: # cps/templates/detail.html
# Conflicts: # cps/static/css/style.css # cps/templates/detail.html
# Conflicts: # cps/admin.py # Conflicts: # cps/templates/config_view_edit.html
AsherMaximum
force-pushed
the
subtitle-config
branch
2 times, most recently
from
52431e3 to
4389588
Compare
|
Just wanted to add my support for this PR, it's exactly the solution to the issue I reported in #1325. Being able to configure a subtitle column for Kobo sync would be a great QoL improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of changes from janeczku/calibre-web#3376
Issue #1325