Repository navigation
docs(framework-context): distinguish Container benchmark load from threshold regressions - #3499
Merged
Merged
Conversation
…reshold regressions
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3435.
The Container threshold failures reproduce locally during concurrent repository checks. Four independent benchmark runs, including a fresh run at the exact investigation commit, pass all 17 rows with unchanged measurement and gate inputs. The note records the workload, raw outcomes, baseline advisories, and triage boundaries so those failures can be assessed without increasing limits or discarding evidence.
Registration and validation p75 in the exact-commit run are 2.983 ms and 3.371 ms, below even the local 10/20 ms limits. Local attempts remain failed: registration 16.166/19.044 ms; validation 16.211/39.942 ms. A separate CPU diagnostic demonstrates off-CPU delays, but the precise cause of the earlier failures remains unresolved. This does not claim a local transient pass or runtime repair.
Validation
Head:
86caf43bf0df8679116adf6caa4916d1ee535ebcValidated base:
0e786bfbddf6cd983e1e62d88ed0f30d6d2aee9e.Integration validation
All four required checks pass:
benchmark-gate,docs-sync-check,repository-contracts, andvalidate. CI 38132382432 also passes core verification, generated apps, package artifacts, coverage/security, docs build, and split validation. Benchmark gate 38132382419 and companion 38132382562 pass. The CI checkout identity is verified as candidate1e840215891e8e61fa7417c3a785249f515cb0eb, base4d3b429eff1cbe0ecd3442154f971a77a4155341, and unchanged head86caf43bf0df8679116adf6caa4916d1ee535ebc.The earlier independent registry failure was resolved by #3502. The first reopened run still inspected the old candidate; its failures remain preserved and are superseded by the verified current-candidate result above.
Current base:
a6ce270e5cc1c766891baf860b0a581eb3b20ba9. Cumulative drift includes the registry source-location repair, QStash failure-recording error preservation, and admin-generated null literal handling. None interacts with the benchmark workload, gates, or investigation findings. Existing head evidence remains applicable; later drift has been assessed for compatibility without claiming it was covered by the earlier CI checkout. No rebase or authored-source change was needed. No requested changes, unresolved review threads, or blocking issue comments remain.