Repository navigation
fix(protocols-trpc): apply controller pipes to client input arguments - #3482
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📊 Benchmark Results✅ All benchmarks passed
Updated: 2026-10-11T12:28:21.903Z · Commit: a9a9d80 |
kang-heewon
force-pushed
the
fix/3206-trpc-pipes
branch
from
October 10, 2026 11:59
2d2dc7f to
8f3b726
Compare
kang-heewon
force-pushed
the
fix/3206-trpc-pipes
branch
from
October 11, 2026 11:27
0cb4b21 to
a9a9d80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3206.
Behavior change
Controller and method
@UsePipestransform tRPC body, path, query, and header arguments in class → method order. Async pipes run inside the interceptor-wrapped request lifecycle, injected providers use the request context, and failures reach the existing Problem/filter pipeline. Context, raw, and authentication arguments retain their existing values.Input schemas run before tRPC pipes. The README documents this ordering relative to HTTP parameter validation. The input envelope and public types are unchanged.
Validation
{name: "Ada"}once per request on both transports.pnpm checkpassed, including architecture, Problem registry, public API, inventory, and repository contracts.Residual risk
Pipes receive schema-parsed tRPC input and cannot repair values rejected by the input schema. This parser order is documented and tested.