Data loss in cleanup_orphaned_tool_results with custom association#584
Open
bschmeck wants to merge 2 commits intocrmne:mainfrom
Open
Data loss in cleanup_orphaned_tool_results with custom association#584bschmeck wants to merge 2 commits intocrmne:mainfrom
bschmeck wants to merge 2 commits intocrmne:mainfrom
Conversation
We wind up plucking the wrong column because of a custom column name
Author
|
#515 fixes a similar class of bug in the same method. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Following an error, the
cleanup_orphaned_tool_resultsensures that associations are properly built by comparing the tool call message'stool_calls to the foreign keys on the tool call message's tool results. We do this by plucking the ids of the tool calls and the tool call foreign keys of the tool call results. The name of the foreign key column to pluck is hardcoded as:tool_call_id, but a custom association may result in a different column name. In that situation, we wind up plucking thetool_call_idcolumn from thetool_callstable, which is an identifier from the LLM provider, not a database id. There is guaranteed to be a mismatch, which results in tool calls and results being destroyed because they are incorrectly believed to be orphaned.This change uses reflection to discover the name of the foreign key before plucking the column.
There is a single spec that demonstrates the failure, I'm happy to expand the test cases if there is interest in this change.
Fixes #583
Type of change
Scope check
Required for new features
PRs for new features or enhancements without a prior approved issue will be closed.
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)AI-generated code
API changes