Skip to content

Preserves assume_model_exists in to_llm for custom models #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
creaumond wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Preserves assume_model_exists in to_llm for custom models #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/ruby_llm/active_record/chat_methods.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ def to_llm
model_record = model_association
@chat ||= (context || RubyLLM).chat(
model: model_record.model_id,
provider: model_record.provider.to_sym
provider: model_record.provider.to_sym,
assume_model_exists: assume_model_exists || false
)
@chat.reset_messages!

Expand Down
6 changes: 4 additions & 2 deletions spec/ruby_llm/active_record/acts_as_model_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,8 @@ def messages
# Mock the chat creation to verify parameters
expect(RubyLLM).to receive(:chat).with( # rubocop:disable RSpec/MessageSpies,RSpec/StubbedMock
model: 'test-gpt',
provider: :openai
provider: :openai,
assume_model_exists: false
).and_return(
instance_double(RubyLLM::Chat, reset_messages!: nil, add_message: nil,
instance_variable_get: {}, on_new_message: nil, on_end_message: nil,
Expand All @@ -272,7 +273,8 @@ def messages

expect(RubyLLM).to receive(:chat).with( # rubocop:disable RSpec/MessageSpies,RSpec/StubbedMock
model: 'test-claude',
provider: :anthropic
provider: :anthropic,
assume_model_exists: false
).and_return(
instance_double(RubyLLM::Chat, reset_messages!: nil, add_message: nil,
instance_variable_get: {}, on_new_message: nil, on_end_message: nil,
Expand Down
8 changes: 8 additions & 0 deletions spec/ruby_llm/active_record/acts_as_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,14 @@ class ToolCall < ActiveRecord::Base # rubocop:disable RSpec/LeakyConstantDeclara
expect(llm_tool_call.name).to eq('calculator')
expect(llm_tool_call.arguments).to eq({ 'expression' => '2 + 2' })
end

it 'correctly preserves custom model' do
custom_model = 'my-custom-model'
bot_chat = Assistants::BotChat.create!(model: custom_model, assume_model_exists: true, provider: 'openrouter')
bot_chat.save!
llm_chat = bot_chat.to_llm
expect(llm_chat.model.id).to eq(custom_model)
end
end
end

Expand Down