-
-
Notifications
You must be signed in to change notification settings - Fork 271
Feat: Add support to Action Text enabled content #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Improved the `extract_content` method to correctly process Action Text. When `message` model uses `has_rich_text :content`, `message.content` becomes `ActionText:RichText`, returning HTML tags unintentionally. Adjustments ensure only the desired content is extracted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some tests?
@crmne Added basic tests and modified dummy app for instance double. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
==========================================
+ Coverage 84.65% 84.68% +0.02%
==========================================
Files 35 35
Lines 1825 1828 +3
Branches 492 494 +2
==========================================
+ Hits 1545 1548 +3
Misses 280 280 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What this does
Improved the
extract_content
method to correctly process Action Text. Whenmessage
model useshas_rich_text :content
,message.content
becomesActionText:RichText
, returning HTML tags unintentionally. Adjustments ensure only the desired content is extracted.Type of change
Scope check
Quality check
overcommit --install
and all hooks passmodels.json
,aliases.json
)API changes
Related issues