Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 23, 2025

Problem

The CliConstants and CoreConstants classes contained 5 duplicated constant definitions, violating the DRY (Don't Repeat Yourself) principle and creating potential maintenance issues.

Solution

This PR consolidates all duplicated constants into CoreConstants (the base library) and updates all references throughout the codebase. Since the cmf-cli project already depends on the core project, having shared constants defined once in CoreConstants is the architecturally correct approach.

Changes

Removed from CliConstants.cs:

  • FolderInstallDependencies = "installDependencies"
  • DeploymentFrameworkManifestFileName = "manifest.xml"
  • CmfPackageFileName = "cmfpackage.json"
  • RootPackageDefaultKeyword = "cmf-root-package"
  • NpmJsUrl = "https://registry.npmjs.com"

Updated References:

  • 24 files across cmf-cli and tests projects updated to reference CoreConstants instead of CliConstants
  • Added necessary using Cmf.CLI.Core.Constants; import statements where required

Benefits

  1. Single Source of Truth: Each constant is now defined exactly once
  2. Easier Maintenance: Changes to constant values only need to be made in one place
  3. Consistency: All projects reference the same canonical definition
  4. No Functional Changes: This is pure refactoring with no behavioral changes

Verification

  • ✅ Solution builds successfully with no errors or warnings
  • ✅ Zero duplicated constants remain between the two files
  • ✅ All references properly updated and verified

Fixes #<issue_number>

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 0t3vsblobprodcus362.vsblob.vsassets.io
    • Triggering command: dotnet build cmf-cli.sln (dns block)
  • 1javsblobprodcus364.vsblob.vsassets.io
    • Triggering command: dotnet build cmf-cli.sln (dns block)
  • 1k9vsblobprodcus379.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/cli/tests/bin/Debug/net8.0/resources/template_feed/iot/driver-dotnet-framework/src/%directoryname%/dotnet/Cmf.Connect.IoT.Driver.%driveridentifier%/Cmf.Connect.IoT.Driver.%driveridentifier%.csproj --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
  • 2kmvsblobprodcus39.vsblob.vsassets.io
  • 2zrvsblobprodcus388.vsblob.vsassets.io
    • Triggering command: dotnet build cmf-cli.sln (dns block)
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/2FDB0CE82C286052218729A02AE6F73C/missingpackages_workingdir --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/805D52E7EE3FA52FA925C0777AB38A1A/missingpackages_workingdir --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • 37bvsblobprodcus311.vsblob.vsassets.io
    • Triggering command: dotnet build cmf-cli.sln (dns block)
  • 4m6vsblobprodcus384.vsblob.vsassets.io
    • Triggering command: dotnet build cmf-cli.sln (dns block)
  • 4vyvsblobprodcus361.vsblob.vsassets.io
  • 4zjvsblobprodcus390.vsblob.vsassets.io
    • Triggering command: dotnet build cmf-cli.sln (dns block)
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/2FDB0CE82C286052218729A02AE6F73C/missingpackages_workingdir --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/805D52E7EE3FA52FA925C0777AB38A1A/missingpackages_workingdir --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • 51yvsblobprodcus36.vsblob.vsassets.io
    • Triggering command: dotnet build cmf-cli.sln (dns block)
  • 5dkvsblobprodcus355.vsblob.vsassets.io
    • Triggering command: dotnet build cmf-cli.sln (dns block)
  • 5rqvsblobprodcus385.vsblob.vsassets.io
  • 7k6vsblobprodcus337.vsblob.vsassets.io
  • 7tjvsblobprodcus341.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/2FDB0CE82C286052218729A02AE6F73C/missingpackages_workingdir --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • 80zvsblobprodcus35.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/cli/tests/bin/Debug/net8.0/resources/template_feed/iot/driver-dotnet-framework/src/%directoryname%/dotnet/Cmf.Connect.IoT.Driver.%driveridentifier%/Cmf.Connect.IoT.Driver.%driveridentifier%.csproj --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/805D52E7EE3FA52FA925C0777AB38A1A/missingpackages_workingdir --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • bcnvsblobprodcus378.vsblob.vsassets.io
  • c50vsblobprodcus330.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/cli/cmf-cli/resources/template_feed/iot/driver-dotnet-framework/src/%directoryname%/dotnet/Cmf.Connect.IoT.Driver.%driveridentifier%/Cmf.Connect.IoT.Driver.%driveridentifier%.csproj --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
  • c78vsblobprodcus322.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/805D52E7EE3FA52FA925C0777AB38A1A/missingpackages_workingdir --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • cmf-nuget
    • Triggering command: npm install (dns block)
  • frdvsblobprodcus327.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/cli/cmf-cli/resources/template_feed/iot/driver-dotnet-framework/src/%directoryname%/dotnet/Cmf.Connect.IoT.Driver.%driveridentifier%/Cmf.Connect.IoT.Driver.%driveridentifier%.csproj --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/cli/cmf-cli/bin/Debug/resources/template_feed/iot/driver-dotnet-framework/src/%directoryname%/dotnet/Cmf.Connect.IoT.Driver.%driveridentifier%/Cmf.Connect.IoT.Driver.%driveridentifier%.csproj --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/cli/tests/bin/Debug/net8.0/resources/template_feed/iot/driver-dotnet-framework/src/%directoryname%/dotnet/Cmf.Connect.IoT.Driver.%driveridentifier%/Cmf.Connect.IoT.Driver.%driveridentifier%.csproj --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
  • gbsvsblobprodcus365.vsblob.vsassets.io
  • gervsblobprodcus329.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/cli/tests/bin/Debug/net8.0/resources/template_feed/iot/driver-dotnet-framework/src/%directoryname%/dotnet/Cmf.Connect.IoT.Driver.%driveridentifier%/Cmf.Connect.IoT.Driver.%driveridentifier%.csproj --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
  • h6tvsblobprodcus346.vsblob.vsassets.io
    • Triggering command: dotnet build cmf-cli.sln (dns block)
  • jd4vsblobprodcus366.vsblob.vsassets.io
    • Triggering command: dotnet build cmf-cli.sln (dns block)
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/cli/cmf-cli/resources/template_feed/iot/driver-dotnet-framework/src/%directoryname%/dotnet/Cmf.Connect.IoT.Driver.%driveridentifier%/Cmf.Connect.IoT.Driver.%driveridentifier%.csproj --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/cli/tests/bin/Debug/net8.0/resources/template_feed/iot/driver-dotnet-framework/src/%directoryname%/dotnet/Cmf.Connect.IoT.Driver.%driveridentifier%/Cmf.Connect.IoT.Driver.%driveridentifier%.csproj --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
  • jrqvsblobprodcus343.vsblob.vsassets.io
  • k0ivsblobprodcus356.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/C5FB799EDCBCE6E42AAC137FC50336BD/missingpackages_workingdir --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • kgfvsblobprodcus314.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/805D52E7EE3FA52FA925C0777AB38A1A/missingpackages_workingdir --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/2FDB0CE82C286052218729A02AE6F73C/missingpackages_workingdir --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • kh4vsblobprodcus325.vsblob.vsassets.io
    • Triggering command: dotnet build cmf-cli.sln (dns block)
  • kijvsblobprodcus387.vsblob.vsassets.io
  • kmuvsblobprodcus389.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/C5FB799EDCBCE6E42AAC137FC50336BD/missingpackages_workingdir --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • kxqvsblobprodcus376.vsblob.vsassets.io
    • Triggering command: dotnet build cmf-cli.sln (dns block)
  • l49vsblobprodcus358.vsblob.vsassets.io
    • Triggering command: dotnet build cmf-cli.sln (dns block)
  • ljcvsblobprodcus317.vsblob.vsassets.io
  • m16vsblobprodcus374.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/71D8F1331231B3366990DDCEAEF101CB/missingpackages_workingdir --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • m6xvsblobprodcus342.vsblob.vsassets.io
  • m8dvsblobprodcus37.vsblob.vsassets.io
  • nn8vsblobprodcus340.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/cli/tests/bin/Debug/net8.0/resources/template_feed/iot/driver-dotnet-framework/src/%directoryname%/dotnet/Cmf.Connect.IoT.Driver.%driveridentifier%/Cmf.Connect.IoT.Driver.%driveridentifier%.csproj --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/805D52E7EE3FA52FA925C0777AB38A1A/missingpackages_workingdir --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • ofvvsblobprodcus315.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/cli/tests/bin/Debug/net8.0/resources/template_feed/iot/driver-dotnet-framework/src/%directoryname%/dotnet/Cmf.Connect.IoT.Driver.%driveridentifier%/Cmf.Connect.IoT.Driver.%driveridentifier%.csproj --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
  • p2ovsblobprodcus312.vsblob.vsassets.io
    • Triggering command: dotnet build cmf-cli.sln (dns block)
  • pkvvsblobprodcus321.vsblob.vsassets.io
  • rcxvsblobprodcus328.vsblob.vsassets.io
  • s8mvsblobprodcus38.vsblob.vsassets.io
    • Triggering command: dotnet build cmf-cli.sln (dns block)
  • se1vsblobprodcus349.vsblob.vsassets.io
    • Triggering command: dotnet build cmf-cli.sln (dns block)
  • sqdvsblobprodcus333.vsblob.vsassets.io
  • st8vsblobprodcus339.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/2FDB0CE82C286052218729A02AE6F73C/missingpackages_workingdir --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • tphvsblobprodcus375.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/cli/cmf-cli/resources/template_feed/iot/driver-dotnet-framework/src/%directoryname%/dotnet/Cmf.Connect.IoT.Driver.%driveridentifier%/Cmf.Connect.IoT.Driver.%driveridentifier%.csproj --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/cli/tests/bin/Debug/net8.0/resources/template_feed/iot/driver-dotnet-framework/src/%directoryname%/dotnet/Cmf.Connect.IoT.Driver.%driveridentifier%/Cmf.Connect.IoT.Driver.%driveridentifier%.csproj --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/0B4FA94B136BC64912B9EBF5212D856C/missingpackages_workingdir --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • ukkvsblobprodcus352.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/805D52E7EE3FA52FA925C0777AB38A1A/missingpackages_workingdir --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • uy6vsblobprodcus34.vsblob.vsassets.io
    • Triggering command: dotnet build cmf-cli.sln (dns block)
  • v53vsblobprodcus320.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/805D52E7EE3FA52FA925C0777AB38A1A/missingpackages_workingdir --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • vb4vsblobprodcus33.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/cli/tests/bin/Debug/net8.0/resources/template_feed/iot/driver-dotnet-framework/src/%directoryname%/dotnet/Cmf.Connect.IoT.Driver.%driveridentifier%/Cmf.Connect.IoT.Driver.%driveridentifier%.csproj --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
  • vwvvsblobprodcus334.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/cli/tests/bin/Debug/net8.0/resources/template_feed/iot/driver-dotnet-framework/src/%directoryname%/dotnet/Cmf.Connect.IoT.Driver.%driveridentifier%/Cmf.Connect.IoT.Driver.%driveridentifier%.csproj --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
  • x3yvsblobprodcus370.vsblob.vsassets.io
    • Triggering command: dotnet build cmf-cli.sln (dns block)
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/cli/tests/bin/Debug/net8.0/resources/template_feed/iot/driver-dotnet-framework/src/%directoryname%/dotnet/Cmf.Connect.IoT.Driver.%driveridentifier%/Cmf.Connect.IoT.Driver.%driveridentifier%.csproj --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
  • xupvsblobprodcus332.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/cli/tests/bin/Debug/net8.0/resources/template_feed/iot/driver-dotnet-framework/src/%directoryname%/dotnet/Cmf.Connect.IoT.Driver.%driveridentifier%/Cmf.Connect.IoT.Driver.%driveridentifier%.csproj --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
  • yluvsblobprodcus367.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/cli/cli/tests/bin/Debug/net8.0/resources/template_feed/iot/driver-dotnet-framework/src/%directoryname%/dotnet/Cmf.Connect.IoT.Driver.%driveridentifier%/Cmf.Connect.IoT.Driver.%driveridentifier%.csproj --packages /home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/cli/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
  • yttvsblobprodcus357.vsblob.vsassets.io
  • ytvvsblobprodcus310.vsblob.vsassets.io

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>duplicated constants</issue_title>
<issue_description>CliConstants and CoreConstants have a lot of duplicated properties.
this need to be reviewed</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #289


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Review and remove duplicated properties in constants Remove duplicated constants between CliConstants and CoreConstants Oct 23, 2025
Copilot AI requested a review from joaoopereira October 23, 2025 14:37
…ences to CoreConstants

Co-authored-by: joaoopereira <3718704+joaoopereira@users.noreply.github.com>
@joaoopereira joaoopereira force-pushed the copilot/remove-duplicated-constants branch from 6c4f64f to d67b237 Compare October 23, 2025 23:40
@joaoopereira joaoopereira marked this pull request as ready for review October 23, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants