Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR Build of Data is not compiling the DEEs #66

Closed
jrk94 opened this issue Nov 10, 2021 · 0 comments · Fixed by #224
Closed

PR Build of Data is not compiling the DEEs #66

jrk94 opened this issue Nov 10, 2021 · 0 comments · Fixed by #224
Assignees
@joaoopereira
Labels
bug Something isn't working

Comments

@jrk94
Copy link
Collaborator

jrk94 commented Nov 10, 2021

The build of Data should check if the DEEs can be compiled. Right now someone can change a DEE merge with development and then the fact the DEE is not compilable will only be caught by a Business PR.

Also Business Compiling should be explicitly be project and not by solution, because right now it's compiling the DEEs even though they are not part of the Business package
@jrk94 jrk94 self-assigned this Nov 10, 2021
@jrk94 jrk94 added the bug Something isn't working label Nov 10, 2021
@joaoopereira joaoopereira assigned joaoopereira and unassigned jrk94 Sep 13, 2022
joaoopereira added a commit that referenced this issue Sep 16, 2022
@joaoopereira
test(build): add data package build
91126c1 
closes #66
@joaoopereira joaoopereira mentioned this issue Sep 16, 2022
Merged
joaoopereira added a commit that referenced this issue Sep 16, 2022
@joaoopereira
test(build): add data package build
e705b4c 
closes #66
joaoopereira added a commit that referenced this issue Sep 16, 2022
@joaoopereira
test(build): add data package build
692055f 
closes #66
@m-s- m-s- mentioned this issue Oct 17, 2022
Merged
@m-s- m-s- closed this as completed in 0c30318 Oct 17, 2022
@m-s- m-s- closed this as completed in #224 Oct 17, 2022
joaoopereira added a commit that referenced this issue Oct 25, 2022
@joaoopereira
test(build): add data package build
06e7411 
closes #66
joaoopereira added a commit that referenced this issue Oct 25, 2022
@joaoopereira
fix: support BuildablePackages on data packages
c1fa141 
closes #66
m-s- pushed a commit that referenced this issue Oct 25, 2022
@joaoopereira @m-s-
fix: support BuildablePackages on data packages
8110271 
closes #66
This was referenced Dec 5, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaoopereira joaoopereira

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 3.1.2 criticalmanufacturing/cli
2 participants
@joaoopereira @jrk94