Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor publish command to new command assemble #53

Closed
joaoopereira opened this issue Oct 21, 2021 · 2 comments
Closed

refactor publish command to new command assemble #53

joaoopereira opened this issue Oct 21, 2021 · 2 comments
Labels
breaking Solving this issue will imply a major version bump as it breaks compatibility enhancement New feature or request

Comments

@joaoopereira
Copy link
Collaborator

joaoopereira commented Oct 21, 2021 •
edited
Loading

Requirement

  • Gather all packages needed for installation based on a root CmfPackage

Assumption

  • This command should run on a git repo with a cmfpackage.json

Arguments/Options

  • ciRepo
  • Continuous Integration repo (can be a folder or a url)
  • repos
    • List of repositories (can be a folder or a url)
  • outputDir
    • Output directory where the packages will be put

Logic

  • Load root CmfPackage
  • if PackageType is not root, throw exception
  • Call method LoadDependencies
    • with this we should all the local and remote packages
    • if a local package is not found locally or in repository, an exception should be thrown
  • Copy all packages with Location=Local that do not exist in repos list from ciRepo to outputDir
  • Generate json file with all dependencies (Id@Version-Uri) that were not copied
@joaoopereira joaoopereira added enhancement New feature or request breaking Solving this issue will imply a major version bump as it breaks compatibility labels Oct 21, 2021
@joaoopereira
Copy link
Collaborator Author

this issue can also solve the #13

@joaoopereira joaoopereira mentioned this issue Oct 21, 2021
Closed
joaoopereira added a commit that referenced this issue Nov 12, 2021
@joaoopereira
chore: initial rename publish to assemble #53
d95220c
@joaoopereira joaoopereira mentioned this issue Nov 12, 2021
Merged
joaoopereira added a commit that referenced this issue Nov 12, 2021
@joaoopereira
chore: assemble command #53
48a7731
joaoopereira added a commit that referenced this issue Nov 15, 2021
@joaoopereira
chore: assemble command #53
83cf11c
@joaoopereira
Copy link
Collaborator Author

closed by pr #69

@m-s- m-s- mentioned this issue Nov 26, 2021
Merged
@m-s- m-s- mentioned this issue Jan 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Solving this issue will imply a major version bump as it breaks compatibility enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joaoopereira