Skip to content

Hot fix to ensure compatibility with mlflow server >= 1.30.0 #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

Mbompr
Copy link
Contributor

@Mbompr Mbompr commented Mar 7, 2023

Description

With mlflow server 1.30.0 and mlflow client <= 1.23, the following command sends two requests (one with an empty run_name and another with the filled run_name) that collide.

>>> run = mlflow.start_run(run_id=run_id, run_name=run_name)

We thus start the run first, and then set the run_name to maximize compatibility.

Type of change

  • Feature
  • Fix
  • Release

Checklist

@Mbompr Mbompr assigned victor-paltz and Mbompr and unassigned victor-paltz Mar 7, 2023
@Mbompr Mbompr requested a review from victor-paltz March 7, 2023 13:32
@Mbompr Mbompr mentioned this pull request Mar 7, 2023
5 tasks
Copy link

@victor-paltz victor-paltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@Mbompr Mbompr merged commit f660c16 into master Mar 7, 2023
@Mbompr Mbompr deleted the mlflow-hotfix branch March 7, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants