Various Adapters: Delete s2s transform bid params for adapters with n…

…o server equivalent (prebid#11402) * Brightcom adapter: remove adapters (prebid#10925) * Update adagioBidAdapter.js * Update adrelevantisBidAdapter.js * Update big-richmediaBidAdapter.js * Update craftBidAdapter.js * Update goldbachBidAdapter.js * Update winrBidAdapter.js * Update vibrantmediaBidAdapter.js * Update winrBidAdapter.js * Update goldbachBidAdapter.js * Update craftBidAdapter.js * Update adrelevantisBidAdapter.js * Revert "Brightcom adapter: remove adapters (prebid#10925)" (prebid#11404) This reverts commit 878f737. * Update goldbachBidAdapter.js * Update goldbachBidAdapter.js * Update adagioBidAdapter_spec.js * Update big-richmediaBidAdapter_spec.js * Update vibrantmediaBidAdapter_spec.js * Update vibrantmediaBidAdapter_spec.js --------- Co-authored-by: Alexandru <prBigBrother@users.noreply.github.com>
criteo-forks · May 14, 2024 · 016e6f9 · 016e6f9
1 parent 5bb8498
commit 016e6f9
Show file tree

Hide file tree

Showing 10 changed files with 8 additions and 205 deletions.
diff --git a/modules/adagioBidAdapter.js b/modules/adagioBidAdapter.js
@@ -1275,20 +1275,6 @@ export const spec = {
 
     return syncs;
   },
-
-  /**
-   * Handle custom logic in s2s context
-   *
-   * @param {*} params
-   * @param {boolean} isOrtb Is an s2s context
-   * @param {*} adUnit
-   * @param {*} bidRequests
-   * @returns {object} updated params
-   */
-  transformBidParams(params, isOrtb, adUnit, bidRequests) {
-    // We do not have a prebid server adapter. So let's return unchanged params.
-    return params;
-  }
 };
 
 initAdagio();

diff --git a/modules/adrelevantisBidAdapter.js b/modules/adrelevantisBidAdapter.js
@@ -18,9 +18,7 @@ import {BANNER, NATIVE, VIDEO} from '../src/mediaTypes.js';
 import {find, includes} from '../src/polyfill.js';
 import {INSTREAM, OUTSTREAM} from '../src/video.js';
 import { convertOrtbRequestToProprietaryNative } from '../src/native.js';
-import {getANKeywordParam, transformBidderParamKeywords} from '../libraries/appnexusUtils/anKeywords.js';
-import {convertCamelToUnderscore} from '../libraries/appnexusUtils/anUtils.js';
-import {convertTypes} from '../libraries/transformParamsUtils/convertTypes.js';
+import {getANKeywordParam} from '../libraries/appnexusUtils/anKeywords.js';
 import {chunk} from '../libraries/chunk/chunk.js';
 
 /**
@@ -187,28 +185,6 @@ export const spec = {
     }
 
     return bids;
-  },
-
-  transformBidParams: function(params, isOpenRtb) {
-    params = convertTypes({
-      'placementId': 'number',
-      'keywords': transformBidderParamKeywords
-    }, params);
-
-    if (isOpenRtb) {
-      params.use_pmt_rule = (typeof params.usePaymentRule === 'boolean') ? params.usePaymentRule : false;
-      if (params.usePaymentRule) { delete params.usePaymentRule; }
-
-      Object.keys(params).forEach(paramKey => {
-        let convertedKey = convertCamelToUnderscore(paramKey);
-        if (convertedKey !== paramKey) {
-          params[convertedKey] = params[paramKey];
-          delete params[paramKey];
-        }
-      });
-    }
-
-    return params;
   }
 };
 

diff --git a/modules/big-richmediaBidAdapter.js b/modules/big-richmediaBidAdapter.js
@@ -112,11 +112,6 @@ export const spec = {
     return baseAdapter.getUserSyncs(syncOptions, responses, gdprConsent);
   },
 
-  transformBidParams: function (params, isOpenRtb) {
-    if (!baseAdapter.transformBidParams) { return params; }
-    return baseAdapter.transformBidParams(params, isOpenRtb);
-  },
-
   /**
    * Add element selector to javascript tracker to improve native viewability
    * @param {Bid} bid

diff --git a/modules/craftBidAdapter.js b/modules/craftBidAdapter.js
@@ -6,9 +6,7 @@ import {getStorageManager} from '../src/storageManager.js';
 import {ajax} from '../src/ajax.js';
 import {hasPurpose1Consent} from '../src/utils/gpdr.js';
 import {convertOrtbRequestToProprietaryNative} from '../src/native.js';
-import {getANKeywordParam, transformBidderParamKeywords} from '../libraries/appnexusUtils/anKeywords.js';
-import {convertCamelToUnderscore} from '../libraries/appnexusUtils/anUtils.js';
-import {convertTypes} from '../libraries/transformParamsUtils/convertTypes.js';
+import {getANKeywordParam} from '../libraries/appnexusUtils/anKeywords.js';
 
 const BIDDER_CODE = 'craft';
 const URL_BASE = 'https://gacraft.jp/prebid-v3';
@@ -101,24 +99,6 @@ export const spec = {
     }
   },
 
-  transformBidParams: function(params, isOpenRtb) {
-    params = convertTypes({
-      'sitekey': 'string',
-      'placementId': 'string',
-      'keywords': transformBidderParamKeywords,
-    }, params);
-    if (isOpenRtb) {
-      Object.keys(params).forEach(paramKey => {
-        let convertedKey = convertCamelToUnderscore(paramKey);
-        if (convertedKey !== paramKey) {
-          params[convertedKey] = params[paramKey];
-          delete params[paramKey];
-        }
-      });
-    }
-    return params;
-  },
-
   onBidWon: function(bid) {
     ajax(bid._prebidWon, null, null, {
       method: 'POST',

diff --git a/modules/goldbachBidAdapter.js b/modules/goldbachBidAdapter.js
@@ -24,9 +24,8 @@ import {INSTREAM, OUTSTREAM} from '../src/video.js';
 import {hasPurpose1Consent} from '../src/utils/gpdr.js';
 import {convertOrtbRequestToProprietaryNative} from '../src/native.js';
 import {APPNEXUS_CATEGORY_MAPPING} from '../libraries/categoryTranslationMapping/index.js';
-import {getANKeywordParam, transformBidderParamKeywords} from '../libraries/appnexusUtils/anKeywords.js';
+import {getANKeywordParam} from '../libraries/appnexusUtils/anKeywords.js';
 import {convertCamelToUnderscore, fill} from '../libraries/appnexusUtils/anUtils.js';
-import {convertTypes} from '../libraries/transformParamsUtils/convertTypes.js';
 import {chunk} from '../libraries/chunk/chunk.js';
 
 /**
@@ -386,31 +385,6 @@ export const spec = {
     }
   },
 
-  transformBidParams: function (params, isOpenRtb) {
-    params = convertTypes({
-      'member': 'string',
-      'invCode': 'string',
-      'placementId': 'number',
-      'keywords': transformBidderParamKeywords,
-      'publisherId': 'number'
-    }, params);
-
-    if (isOpenRtb) {
-      params.use_pmt_rule = (typeof params.usePaymentRule === 'boolean') ? params.usePaymentRule : false;
-      if (params.usePaymentRule) { delete params.usePaymentRule; }
-
-      Object.keys(params).forEach(paramKey => {
-        let convertedKey = convertCamelToUnderscore(paramKey);
-        if (convertedKey !== paramKey) {
-          params[convertedKey] = params[paramKey];
-          delete params[paramKey];
-        }
-      });
-    }
-
-    return params;
-  },
-
   /**
    * Add element selector to javascript tracker to improve native viewability
    * @param {Bid} bid

diff --git a/modules/vibrantmediaBidAdapter.js b/modules/vibrantmediaBidAdapter.js
@@ -97,17 +97,6 @@ export const spec = {
   code: BIDDER_CODE,
   supportedMediaTypes: SUPPORTED_MEDIA_TYPES,
 
-  /**
-   * Transforms the 'raw' bid params into ones that this adapter can use, prior to creating the bid request.
-   *
-   * @param {object} bidParams the params to transform.
-   *
-   * @returns {object} the bid params.
-   */
-  transformBidParams: function(bidParams) {
-    return bidParams;
-  },
-
   /**
    * Determines whether or not the given bid request is valid. For all bid requests passed to the buildRequests
    * function, each will have been passed to this function and this function will have returned true.

diff --git a/modules/winrBidAdapter.js b/modules/winrBidAdapter.js
@@ -14,9 +14,8 @@ import {BANNER} from '../src/mediaTypes.js';
 import {find, includes} from '../src/polyfill.js';
 import {getStorageManager} from '../src/storageManager.js';
 import {hasPurpose1Consent} from '../src/utils/gpdr.js';
-import {getANKeywordParam, transformBidderParamKeywords} from '../libraries/appnexusUtils/anKeywords.js';
+import {getANKeywordParam} from '../libraries/appnexusUtils/anKeywords.js';
 import {convertCamelToUnderscore} from '../libraries/appnexusUtils/anUtils.js';
-import {convertTypes} from '../libraries/transformParamsUtils/convertTypes.js';
 
 /**
  * @typedef {import('../src/adapters/bidderFactory.js').BidRequest} BidRequest
@@ -312,39 +311,6 @@ export const spec = {
       ];
     }
   },
-
-  transformBidParams: function (params, isOpenRtb) {
-    params = convertTypes(
-      {
-        member: 'string',
-        invCode: 'string',
-        placementId: 'number',
-        keywords: transformBidderParamKeywords,
-        publisherId: 'number',
-      },
-      params
-    );
-
-    if (isOpenRtb) {
-      params.use_pmt_rule =
-        typeof params.usePaymentRule === 'boolean'
-          ? params.usePaymentRule
-          : false;
-      if (params.usePaymentRule) {
-        delete params.usePaymentRule;
-      }
-
-      Object.keys(params).forEach((paramKey) => {
-        let convertedKey = convertCamelToUnderscore(paramKey);
-        if (convertedKey !== paramKey) {
-          params[convertedKey] = params[paramKey];
-          delete params[paramKey];
-        }
-      });
-    }
-
-    return params;
-  },
 };
 
 function formatRequest(payload, bidderRequest) {

diff --git a/test/spec/modules/adagioBidAdapter_spec.js b/test/spec/modules/adagioBidAdapter_spec.js
@@ -1465,33 +1465,6 @@ describe('Adagio bid adapter', () => {
     });
   });
 
-  describe('transformBidParams', function() {
-    it('Compute additional params in s2s mode', function() {
-      const adUnit = {
-        code: 'adunit-code',
-        params: {
-          organizationId: '1000'
-        }
-      };
-      const bid01 = new BidRequestBuilder({
-        'mediaTypes': {
-          banner: { sizes: [[300, 250]] },
-          video: {
-            context: 'outstream',
-            playerSize: [300, 250],
-            renderer: {
-              url: 'https://url.tld',
-              render: () => true
-            }
-          }
-        }
-      }).withParams().build();
-
-      const params = spec.transformBidParams({ param01: 'test' }, true, adUnit, [{ bidderCode: 'adagio', auctionId: bid01.auctionId, bids: [bid01] }]);
-      expect(params.param01).eq('test');
-    });
-  });
-
   describe('Adagio features when prebid in top.window', function() {
     it('should return all expected features when all expected bidder params are available', function() {
       sandbox.stub(window.top.document, 'getElementById').returns(

diff --git a/test/spec/modules/big-richmediaBidAdapter_spec.js b/test/spec/modules/big-richmediaBidAdapter_spec.js
@@ -271,31 +271,6 @@ describe('bigRichMediaAdapterTests', function () {
     });
   });
 
-  describe('transformBidParams', function() {
-    it('cast placementId to number', function() {
-      const adUnit = {
-        code: 'adunit-code',
-        params: {
-          placementId: '456'
-        }
-      };
-      const bid = {
-        params: {
-          placementId: '456'
-        },
-        sizes: [[300, 250]],
-        mediaTypes: {
-          banner: { sizes: [[300, 250]] }
-        }
-      };
-
-      const params = spec.transformBidParams({ placementId: '456' }, true, adUnit, [{ bidderCode: 'bigRichmedia', auctionId: bid.auctionId, bids: [bid] }]);
-
-      expect(params.placement_id).to.exist;
-      expect(params.placement_id).to.be.a('number');
-    });
-  });
-
   describe('onBidWon', function() {
     it('Should not have any error', function() {
       const result = spec.onBidWon({});

diff --git a/test/spec/modules/vibrantmediaBidAdapter_spec.js b/test/spec/modules/vibrantmediaBidAdapter_spec.js
@@ -62,12 +62,6 @@ describe('VibrantMediaBidAdapter', function () {
     });
   });
 
-  describe('transformBidParams', function () {
-    it('transforms bid params correctly', function () {
-      expect(spec.transformBidParams(VALID_VIDEO_BID_PARAMS)).to.deep.equal(VALID_VIDEO_BID_PARAMS);
-    });
-  })
-
   let bidRequest;
 
   beforeEach(function () {
@@ -1077,13 +1071,9 @@ describe('VibrantMediaBidAdapter', function () {
   describe('Flow tests', function () {
     describe('For successive API calls to the public functions', function () {
       it('should succeed with one media type per bid', function () {
-        const transformedBannerBidParams = spec.transformBidParams(VALID_BANNER_BID_PARAMS);
-        const transformedVideoBidParams = spec.transformBidParams(VALID_VIDEO_BID_PARAMS);
-        const transformedNativeBidParams = spec.transformBidParams(VALID_NATIVE_BID_PARAMS);
-
         const bannerBid = {
           bidder: 'vibrantmedia',
-          params: transformedBannerBidParams,
+          params: VALID_BANNER_BID_PARAMS,
           mediaTypes: {
             banner: {
               sizes: DEFAULT_BID_SIZES,
@@ -1097,7 +1087,7 @@ describe('VibrantMediaBidAdapter', function () {
         };
         const videoBid = {
           bidder: 'vibrantmedia',
-          params: transformedVideoBidParams,
+          params: VALID_VIDEO_BID_PARAMS,
           mediaTypes: {
             video: {
               context: OUTSTREAM,
@@ -1112,7 +1102,7 @@ describe('VibrantMediaBidAdapter', function () {
         };
         const nativeBid = {
           bidder: 'vibrantmedia',
-          params: transformedNativeBidParams,
+          params: VALID_NATIVE_BID_PARAMS,
           mediaTypes: {
             native: {
               image: {
@@ -1178,10 +1168,9 @@ describe('VibrantMediaBidAdapter', function () {
       });
 
       it('should succeed with multiple media types for a single bid', function () {
-        const bidParams = spec.transformBidParams(VALID_VIDEO_BID_PARAMS);
         const bid = {
           bidder: 'vibrantmedia',
-          params: bidParams,
+          params: VALID_VIDEO_BID_PARAMS,
           mediaTypes: {
             banner: {
               sizes: DEFAULT_BID_SIZES