Rustup #15
Rustup #15
Conversation
| info!(" {:4} subsectors", subsectors.len()) | ||
| info!(" {:4} nodes", nodes.len()) | ||
| info!(" {:4} sectors", sectors.len()) | ||
| info!(" {:4} things", things.len()); |
There was a problem hiding this comment.
Why didn't I have semicolons here in the first place?....
There was a problem hiding this comment.
They're only recently required due to this PR.
There was a problem hiding this comment.
Yeah I know, just frustrated at me for not putting them anyway.
|
Again, @Ryman, thanks a lot! Work's not allowing me to keep up with Rust these days. I'd like to experiment and see if we can't reuse the WadNameCast impl for &[u8] in the case of &[u8, ..8]. I might have a bit of time later today and tomorrow to check it out. |
|
More breakage! You may want to check the generate_gl_bindings one more carefully, see here for more info. |
|
2 more minor changes, missed adding a build dependency required for clean builds of gl-rs and the in-tree log & regex crates have been depreciated in favor of cargo versions. |
|
Sorry for the delay, Christmas & New Year trip meant no internet access for a while. Once again, thanks a lot for the PR! Now I still need to figure out the remaining rustup problems... |
This will likely fail travis as it's still pending on a fix in rust-sdl2 but you can use a local override in the meantime.
There's a lot of additional cloning on some of the string additions due to a bug in the stdlib at the moment, e.g.
"foo" + "bar".to_string()="barfoo".