Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent space splitting break the disk name #18

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Prevent space splitting break the disk name #18

merged 1 commit into from
Apr 30, 2021

Conversation

kimlimjustin
Copy link
Contributor

Fix #17

@cristiammercado cristiammercado self-assigned this Apr 30, 2021
@cristiammercado cristiammercado merged commit cd74356 into cristiammercado:master Apr 30, 2021
@cristiammercado
Copy link
Owner

Thanks!

@Ekristoffe
Copy link
Contributor

offf i havent checked right, those changes are in dist and not in src which mean they will be removed if anyone compile.

This was referenced May 1, 2021
Open
Closed
@kimlimjustin
Copy link
Contributor Author

offf i havent checked right, those changes are in dist and not in src which mean they will be removed if anyone compile.

Oh, sorry, I didn't know that. I recommend to add a contributing guideline to prevent this stupid mistake in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cristiammercado cristiammercado

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mounted name went wrong when there's a space on Linux and Darwin
3 participants
@kimlimjustin @cristiammercado @Ekristoffe