Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML responses #636

Merged
merged 45 commits into from
Jul 15, 2024
Merged

HTML responses #636

merged 45 commits into from
Jul 15, 2024

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented May 7, 2024

fixes #210
relates to #615

Resolves GD-533

Examples of HTML outputs produced:
image
image
image
image

… + HTML/XML/JSON format redirect links in HTML view
@fmigneault fmigneault self-assigned this May 7, 2024
@github-actions github-actions bot added the ci/doc Issue related to documentation of the package label May 7, 2024
@github-actions github-actions bot added feature/oas Issues related to OpenAPI specifications. feature/quotation Issues related to quotation, billing and estimators. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support labels May 7, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 97.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 85.78%. Comparing base (7f3c72c) to head (cef5117).
Report is 334 commits behind head on master.

Files with missing lines Patch % Lines
weaver/formats.py 86.20% 2 Missing and 2 partials ⚠️
weaver/wps_restapi/__init__.py 91.66% 1 Missing and 2 partials ⚠️
weaver/wps_restapi/processes/processes.py 94.11% 1 Missing and 1 partial ⚠️
weaver/wps_restapi/swagger_definitions.py 95.12% 1 Missing and 1 partial ⚠️
weaver/wps_restapi/api.py 98.82% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master     #636    +/-   ##
========================================
  Coverage   85.77%   85.78%            
========================================
  Files          79       79            
  Lines       18951    19068   +117     
  Branches     2929     2958    +29     
========================================
+ Hits        16256    16358   +102     
- Misses       1937     1944     +7     
- Partials      758      766     +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmigneault fmigneault marked this pull request as ready for review July 11, 2024 19:44
@fmigneault
Copy link
Collaborator Author

@languith @Nazim-crim
Ready for review. Waiting on tech to update permissions to add you as reviewers.
Don't need an in-depth review, but feel free to ask questions.
Most of the code base received some tweaks since many endpoints are updated for the new HTML format.
Therefore, it is a good overview of capabilities and various parts of the code to familiarize yourselves.

@fmigneault fmigneault requested a review from languith July 15, 2024 14:12
@fmigneault fmigneault merged commit 007cb57 into master Jul 15, 2024
57 checks passed
@fmigneault fmigneault deleted the html-responses branch July 15, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/cli Issues or features related to CLI operations. feature/db Related to database or datatype manipulation. feature/job Issues related to job execution, reporting and logging. feature/oas Issues related to OpenAPI specifications. feature/providers Issue related to providers convertion to WPS-REST processes. feature/quotation Issues related to quotation, billing and estimators. feature/vault Issue related to Vault storage feature. process/builtin Issue related to builtin application processes process/workflow Related to a Workflow process. process/wps1 Issue related to WPS 1.x processes support process/wps2 Issue related to WPS 2.x processes support process/wps3 Issue related to WPS 3.x (REST-JSON) processes support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] HTML format
2 participants