Make ImageVolume garbage collection work #8408
Conversation
openshift-ci
bot
added
release-note-none
openshift-ci
bot
added
the
approved
saschagrunert
force-pushed
the
oci-volume-container-status
branch
from
704007c
to
c52f4ad
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8408 +/- ##
=======================================
Coverage 49.39% 49.39%
=======================================
Files 153 153
Lines 17140 17144 +4
=======================================
+ Hits 8467 8469 +2
- Misses 7604 7606 +2
Partials 1069 1069 |
saschagrunert
force-pushed
the
oci-volume-container-status
branch
from
c52f4ad
to
402ffbe
Compare
|
@cri-o/cri-o-maintainers PTAL |
|
/approve |
We need to return the image ID for the localhost mount, otherwise the kubelet garbage collection is not able to handle them. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
oci-volume-container-status
branch
from
402ffbe
to
3a25632
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/ci-cgroupv2-integration |
|
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-cgroupv2-integration In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/ci-cgroupv2-e2e-crun |
|
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-cgroupv2-e2e-crun, ci/prow/ci-crun-e2e, ci/prow/e2e-gcp-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/ci-cgroupv2-e2e-crun |
|
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-cgroupv2-e2e-crun, ci/prow/ci-crun-e2e, ci/prow/e2e-gcp-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/ci-cgroupv2-integration |
|
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-cgroupv2-integration In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-ovn |
|
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
We need to return the image ID for the localhost mount, otherwise the kubelet garbage collection is not able to handle them.
Which issue(s) this PR fixes:
Refers to kubernetes/enhancements#4639
Follow-up on #8317
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?