Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix wrong session attributes #456

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hf
Copy link
Contributor

@hf hf commented Aug 14, 2022

Some attributes have wrong OIDs or names. This fixes it.

@crewjam
Copy link
Owner

crewjam commented Jan 12, 2023

I'm not sure I understand what is happening here. Can you help me a bit?

@crewjam
Copy link
Owner

crewjam commented Jan 12, 2023

@@ -658,8 +658,8 @@ func (DefaultAssertionMaker) MakeAssertion(req *IdpAuthnRequest, session *Sessio

if session.UserEmail != "" {
attributes = append(attributes, Attribute{
FriendlyName: "eduPersonPrincipalName",
Name: "urn:oid:1.3.6.1.4.1.5923.1.1.1.6",
FriendlyName: "mail",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned that this one might break people. Should we have both attributes?

@@ -704,7 +704,7 @@ func (DefaultAssertionMaker) MakeAssertion(req *IdpAuthnRequest, session *Sessio

if session.UserScopedAffiliation != "" {
attributes = append(attributes, Attribute{
FriendlyName: "uid",
FriendlyName: "scopedAffiliation",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one looks okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants