-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/use converter instead of manually trimming #894
Merged
joaomdmoura
merged 15 commits into
crewAIInc:main
from
bhancockio:feature/use-converter-instead-of-manually-trimming
Jul 15, 2024
Merged
Feature/use converter instead of manually trimming #894
joaomdmoura
merged 15 commits into
crewAIInc:main
from
bhancockio:feature/use-converter-instead-of-manually-trimming
Jul 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomdmoura
approved these changes
Jul 15, 2024
bhancockio
added a commit
that referenced
this pull request
Jan 2, 2025
* Exploring output being passed to tool selector to see if we can better format data * WIP. Adding JSON repair functionality * Almost done implementing JSON repair. Testing fixes vs current base case. * More action cleanup with additional tests * WIP. Trying to figure out what is going on with tool descriptions * Update tool description generation * WIP. Trying to find out what is causing the tools to duplicate * Replacing tools properly instead of duplicating them accidentally * Fixing issues for MR * Update dependencies for JSON_REPAIR * More cleaning up pull request * preppering for call * Fix type-checking issues --------- Co-authored-by: João Moura <joaomdmoura@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This pull request includes several key changes and improvements aimed at enhancing the overall functionality and efficiency of our system. The most notable updates are as follows:
Improved Action Inputs Handling:
Enhanced the way action and action inputs are fed to the LLMs. This improvement is crucial as it addresses the issue where weaker LLMs struggled to generate valid JSON. By refining this process, we ensure more reliable and accurate outputs from the LLMs.
Tool Delegation Fixes:
Resolved an issue where the crew continually added delegation tools repeatedly. This was causing confusion for the LLMs, leading to errors in tool selection and bloating the context window with duplicate text. The fix ensures that delegation tools are added correctly without redundancy.
Updated Tool Descriptions:
Revised the tool descriptions to be clearer and easier to read. This change is aimed at improving the LLMs' ability to accurately pick and use the appropriate tools, enhancing the overall user experience and functionality.
Detailed Changes:
Action Inputs: Improved the JSON formatting and validation for action inputs to ensure compatibility with various LLMs.
Tool Delegation: Implemented checks to prevent the repeated addition of delegation tools, ensuring a cleaner and more efficient context.
Tool Descriptions: Simplified and clarified the language in tool descriptions for better understanding and selection by the LLMs.