fix: initialize tools list when None before extending with MCP/platform tools#4645
Open
giulio-leone wants to merge 1 commit intocrewAIInc:mainfrom
Open
fix: initialize tools list when None before extending with MCP/platform tools#4645giulio-leone wants to merge 1 commit intocrewAIInc:mainfrom
giulio-leone wants to merge 1 commit intocrewAIInc:mainfrom
Conversation
…rm tools When an Agent is created with mcps but without explicit tools, self.tools is None. The condition 'mcps and self.tools is not None' silently skips MCP tool loading, so the agent runs with no tools at all. Initialize self.tools to [] before extending when it is None. Applied to both platform_tools and MCP tools branches. Fixes crewAIInc#4568
giulio-leone
force-pushed
the
fix/mcp-tools-none-initialization
branch
from
143ee17 to
f8174e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an Agent is created with
mcpsbut without explicittools,self.toolsisNone. The condition at line 1163:silently skips MCP tool loading because
self.tools is not Noneevaluates toFalse. The agent runs with no tools.The same issue exists for
platform_toolsat line 1159.Fix
Initialize
self.toolsto[]before calling.extend()when it isNone.Fixes #4568
Note
Low Risk
Low risk bug fix that only changes how
Agent._prepare_kickoffappends platform/MCP tools whenself.toolsis unset; minimal behavioral impact beyond correctly enabling tool loading.Overview
Fixes standalone
Agentkickoff tool initialization so platform app tools and MCP tools are still added whenself.toolsstarts asNone._prepare_kickoffnow initializesself.toolsto an empty list before calling.extend()for platform/MCP tool lists, preventing those integrations from being silently skipped.Written by Cursor Bugbot for commit f8174e6. This will update automatically on new commits. Configure here.