Fix Pydantic validation error when saving to memory#4623
Open
Anandesh-Sharma wants to merge 1 commit intocrewAIInc:mainfrom
Open
Fix Pydantic validation error when saving to memory#4623Anandesh-Sharma wants to merge 1 commit intocrewAIInc:mainfrom
Anandesh-Sharma wants to merge 1 commit intocrewAIInc:mainfrom
Conversation
Strip markdown code fences from LLM responses before JSON parsing in Converter.to_pydantic() and convert_to_model(). Some LLMs wrap JSON responses in ```json ... ``` blocks, which caused "expected value at line 1 column 1" errors during task evaluation memory saves. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4509
\``json ... ```) from LLM responses before JSON parsing inConverter.to_pydantic()andconvert_to_model()`ValidationError: Invalid JSON: expected value at line 1 column 1during task evaluation memory saves_CODE_BLOCK_PATTERNregex already established inbase_converter_adapter.pyfor consistencyTest plan
_strip_markdown_code_fences()covering: json code fences, plain code fences, no code fences, multiline JSON, surrounding text, plain text passthrough, whitespace strippingConverter.to_pydantic()andconvert_to_model()verifying markdown-wrapped JSON is correctly parsed🤖 Generated with Claude Code